Implement store purchase and download feature - #782
Conversation
alessio-attilio
changed the title
|
For the millionth time, please DO NOT touch things that do not need to change. You do not need to remove comments, you do not need to refactor things, you do not need to reformat things. If for whatever reason you want to refactor them do it in separate commits. Fix the thing you intend to fix, leave the rest as is OR make them separate commits. This is not the first time I am asking this from you. If you can't follow it, please don't contribute. |
|
Yeah, I am not merging slop 
If you can write this yourself, you can split it into separate commits properly. I am not going to waste my time reviewing a 1k single-commit changeset. |
| self.logger.error('Remove from wishlist request failed: %s', error) | ||
| callback(success) | ||
| return | ||
| if ( | ||
| response.data is None | ||
| or response.data.wishlist is None | ||
| or response.data.wishlist.removeFromWishlist is None | ||
| ): | ||
| self.logger.error('Remove from wishlist request returned no data') | ||
| callback(success) | ||
| return |
There was a problem hiding this comment.
So, this change, and all the others similar to it, was added because the exception is explicitly re-raised when running with debug enabled? So in a way make the debugging things not work?
| if not isinstance(reply, QNetworkReply): | ||
| self.logger.error('Network request did not return a QNetworkReply: %r', reply) | ||
| self._fail(item) | ||
| return |
There was a problem hiding this comment.
This is not python requests, this is not how QNetworkManager.get() works. There is no way QNetworkAccessManager won't return a QNetworkReply.
What is the point of this change? What does it even fix?
2 participants
Adds a store purchase and download flow to the Store tab with browse/search filtering, wishlist integration and free-game claiming. Fixes the store API by querying the launcher store GraphQL host and sending the EpicGamesLauncher User-Agent so requests authenticate correctly. Response parsing now bails out on GraphQL errors instead of crashing on None.