Refactors NS and Dream to exist quicker when stopped#444
Open
StephenNneji wants to merge 2 commits into
Open
Conversation
DrPaulSharp
approved these changes
Jul 9, 2026
DrPaulSharp
left a comment
DrPaulSharp
left a comment
Collaborator
There was a problem hiding this comment.
All looks good, works for all plot types and noticeable faster exit on interruption. Just one point to consider.
| % Get max length and its index | ||
| [maxLen, maxPos] = max(lengths); | ||
| maxPos = maxPos(1); | ||
| maxLen = maxLen (1); |
Collaborator
There was a problem hiding this comment.
Are these lines necessary given the docs say the index returned is "the first occurrence of the maximum value of A"?
https://uk.mathworks.com/help/matlab/ref/double.max.html#d127e1109685
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alignALProfilesand make it work for bayes and live plot.