This repository was archived by the owner on Aug 20, 2026. It is now read-only.
fix: adapt scanner pruning for jwalk 0.9 API - #89
Merged
Conversation
jwalk 0.9 renamed DirEntry.read_children_path to read_children; update the directory-prune callback and bump the dependency so Dependabot and CI compile cleanly. Co-authored-by: k2gwv6rzf6 <k2gwv6rzf6@privaterelay.appleid.com>
RazorBackRoar
marked this pull request as ready for review
August 20, 2026 21:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI on Dependabot PR #88 by updating the directory-prune callback for jwalk 0.9 (
read_children_path→read_children) and bumping the dependency.Changed files
src-tauri/Cargo.toml—jwalk0.8 → 0.9src-tauri/src/scanner.rs— useread_children = Nonewhen pruning dev/cache dirsCargo.lock— lockfile sync for jwalk 0.9.0Testing performed
cargo test --workspace(not run in Ubuntu cloud agent; macOS CI is authoritative)Safety notes
Scan pruning behavior unchanged: dev/cache directories are still skipped during walk; exact-hash dedup, Dry-default, and quarantine-never-delete contracts preserved.
Risk
Low — dependency bump plus one-field API rename in existing prune logic.
Verification
CI
qualityworkflow on this PR (macOS).Unverified paths
Local
cargo checkon Linux (toolchain too old for lockfile deps); macOS CI proves compile.