Add simplified logic graph folding - #49
Merged
Merged
Conversation
rollrat
force-pushed
the
codex/logic-graph-or-folding
branch
from
June 14, 2026 14:54
13a092b to
31a2ae9
Compare
Skip simplified and high-level logic graph transforms for cyclic graphs because those passes rely on topological CSE. This keeps feedback-based NBT examples from panicking in the viewer while preserving the raw logic graph fallback.
Keep simplified and high-level logic graph passes useful for feedback-based circuits by skipping only CSE on cyclic graphs. OR folding now skips cyclic OR candidates instead of aborting the whole pass, so acyclic regions in counter examples can still fold and compose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification