fix: move HTTP publish retention to the background scheduler - #538
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: ReflexioAI/reflexio/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 1 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughHTTP publishing now runs inside a scheduler-managed retention context, which skips the inline retention-cap sweep. The context resets on exit. Direct embedded publishes retain their throttled sweep behavior, and the post-publish sweep is measured in a named timing phase. ChangesPublish retention handling
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to HTTP publishing no longer waits for retention housekeeping, while configured row caps remain subject to scheduled enforcement. No identified issue prevents merging after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 44.44% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 4 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Summary
HTTP publishes currently run the embedded library's retention sweep after committing admission and reading coverage. A due sweep checks all capped tables before returning the response. Move that housekeeping to the server's existing retention scheduler so HTTP acknowledgement no longer waits for those queries.
Changes
retention_ms.Test Plan
Production latency attribution and the 5,000 ms target still require post-deployment measurement.
Summary by CodeRabbit