Skip to content

[codex] Fix CodeQL alerts #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rjvs merged 1 commit into from
Jul 4, 2026
Merged

[codex] Fix CodeQL alerts #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions scripts/cage_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,10 +611,7 @@ def valid_kernel_source_archive(source: Path) -> bool:

def download_kernel_source(kernel: Path, source_url: str) -> None:
tmp = kernel / "source.tar.xz.tmp"
try:
tmp.unlink()
except FileNotFoundError:
pass
tmp.unlink(missing_ok=True)
try:
run(
[
Expand All @@ -630,10 +627,7 @@ def download_kernel_source(kernel: Path, source_url: str) -> None:
except subprocess.CalledProcessError as exc:
raise SystemExit(f"failed to download kernel source from {source_url}") from exc
if not valid_kernel_source_archive(tmp):
try:
tmp.unlink()
except FileNotFoundError:
pass
tmp.unlink(missing_ok=True)
raise SystemExit(f"downloaded kernel source is not a valid .tar.xz archive: {source_url}")
tmp.replace(kernel / "source.tar.xz")

Expand Down Expand Up @@ -824,10 +818,7 @@ def prepare_release_dir(release_dir: Path) -> None:
*(profile_compressed_asset_name(KERNEL_PROFILES[name]) for name in PUBLISHED_PROFILE_ORDER),
}
for name in asset_names:
try:
(release_dir / name).unlink()
except FileNotFoundError:
pass
(release_dir / name).unlink(missing_ok=True)


def package_release(args: argparse.Namespace) -> int:
Expand Down Expand Up @@ -1160,8 +1151,7 @@ def self_test() -> int:
candidates = kernel_source_candidates(releases, "6.18")
if candidates[:2] != [
"https://cdn.kernel.org/pub/linux/kernel/v6.x/linux-6.18.37.tar.xz",
"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/"
"snapshot/linux-6.18.37.tar.gz",
kernel_snapshot_url("6.18.37"),
]:
raise AssertionError("failed to order latest non-EOL kernel source candidates")
if profile_from_args(argparse.Namespace(profile=DEFAULT_PROFILE_NAME)).name != "hotplug":
Expand Down