Conversation
Fail closed on zero/negative/bool/NaN timeouts before waiting on a Future so callers get a clear ValueError instead of ambiguous wait behavior. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
Bartok9
force-pushed
the
aerial/future-result-timeout-positive
branch
from
August 12, 2026 17:25
0f57bf1 to
76299c4
Compare
Member
|
This one already landed with #824, ros_async.py rejects a non-positive timeout_sec on main today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fail closed on invalid get_future_result timeouts so waits are never zero/negative/bool/NaN.
Testing
Claim: bartok
Operator: bartok
Campaign: aerial-drone