Conversation
ThreadPoolExecutor rejects non-positive max_workers with a generic error. Validate callback_max_workers as a positive int up front on BaseConnector. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
Bartok9
force-pushed
the
aerial/callback-max-workers-positive
branch
from
August 12, 2026 17:25
983af30 to
3affc4a
Compare
Member
|
Already on main via #824, see base_connector.py:75. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate
BaseConnector(callback_max_workers=...)is a positive int before constructing ThreadPoolExecutor. Unit tests for reject/accept paths.AI-assisted; human-reviewed.
Claim: bartok
Operator: bartok
Campaign: aerial-drone