Updating how the font loaded via data-uri is called - #2
Open
moliver-hemasystems wants to merge 1 commit into
Open
moliver-hemasystems wants to merge 1 commit into
moliver-hemasystems wants to merge 1 commit into
Conversation
Recently, on some OSes (like MacOS Monterey), the check using the truetype font via data-uri started throwing the following error (provided by Firefox v93.0): ``` downloadable font: not usable by platform (font-family: "pixelambacht" style:normal weight:400 stretch:100 src index:0) source: data:font/truetype;base64,AAEAAAALAIAAAwAwT1MvMghABuMAAAC8AAAAYGNtYXAAlQDaAAABHAAAAGRnYXNw//8ABAAAAYAAAAAIZ2x5Zv8nt3kAAAGIAAAATG … AQQJAAQAAgAOAAMAAQQJAAUAAAAAAAMAAQQJAAYAAAAAAAMAAQQJAAoAAAAAAAD+/wBy/v8Ab/7/AGX+/wBsAAMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= ``` Updating how the data-uri was set to include things like `format()` seemed to resolve the errors, but Firefox was still warning: ``` downloadable font: no supported format found (font-family: "pixelambacht" style:normal weight:400 stretch:100 src index:1) source: (end of source list) ``` ... and the check was still failing when it should have been passing. Changing to use the WOFF font instead of the TrueType font resolved the warning, and allowed the check to work properly again.
Author
|
I wanted to also point out that the previous version was also getting a warning from Firefox about: However, the version in the PR also results in this warning, just with the updated source. It doesn't seem to affect anything as far as I can tell. |
Author
|
Also, according to caniuse.com, woff seems to have better browser support now than ttf, so this should hopefully be an acceptable change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, on some OSes (like MacOS Monterey), the check using the truetype font via data-uri started throwing the following error (provided by Firefox v93.0):
This was resulting in the check failing when it should have been passing.
Updating how the data-uri was set to include things like
format()seemed to resolve the errors, but Firefox was still warning:... and the check was still failing when it should have been passing.
Changing to use the WOFF font instead of the TrueType font resolved the warning, and allowed the check to work properly again.