Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ bin/rails g

* [Core Setup](./lib/generators/rolemodel/core_setup)
* [Github](./lib/generators/rolemodel/github)
* [Semaphore](./lib/generators/rolemodel/semaphore)
* [Heroku](./lib/generators/rolemodel/heroku)
* [Readme](./lib/generators/rolemodel/readme)
* [Webpack](./lib/generators/rolemodel/webpack)
Expand Down
1 change: 0 additions & 1 deletion lib/generators/rolemodel/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
* [Optics](./optics)
* [README](./readme)
* [SaaS](./saas)
* [Semaphore](./semaphore)
* [SimpleForm](./simple_form)
* [Slim](./slim)
* [SoftDestroyable](./soft_destroyable)
Expand Down
1 change: 0 additions & 1 deletion lib/generators/rolemodel/all_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ class AllGenerator < GeneratorBase

def run_all_the_generators
generate 'rolemodel:github'
generate 'rolemodel:semaphore'
generate 'rolemodel:heroku'
generate 'rolemodel:readme'
generate 'rolemodel:webpack'
Expand Down
55 changes: 55 additions & 0 deletions spec/generators/rolemodel/all_generator_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
RSpec.describe Rolemodel::AllGenerator, type: :generator do
# Each sub-generator is exercised by its own spec, so here we only verify
# which generators get delegated to (and in what order).
let(:invoked_generators) { [] }

before do
# Stub on the Actions module rather than the generator class: stubbing the
# class defines a new public method on it, which Thor would then pick up as
# an additional command to run.
allow_any_instance_of(Rails::Generators::Actions).to receive(:generate) do |_instance, name, *|
invoked_generators << name
end

run_generators
end

it 'delegates to every rolemodel generator in order' do
expect(invoked_generators).to eq([
'rolemodel:github',
'rolemodel:heroku',
'rolemodel:readme',
'rolemodel:webpack',
'rolemodel:sentry',
'rolemodel:react',
'rolemodel:slim',
'rolemodel:optics:all',
'rolemodel:testing:all',
'rolemodel:simple_form',
'rolemodel:soft_destroyable',
'rolemodel:saas:all',
'rolemodel:mailers',
'rolemodel:linters:all',
'rolemodel:ui_components:all',
'rolemodel:source_map',
'rolemodel:good_job',
'rolemodel:kaminari',
'rolemodel:editors',
'rolemodel:lograge'
])
end

it 'only delegates to generators that exist' do
unknown = invoked_generators.reject { |name| Rails::Generators.find_by_namespace(name) }

expect(unknown).to eq([])
end

it 'does not delegate to tailored_select, which is not production ready' do
expect(invoked_generators).not_to include('rolemodel:tailored_select')
end

it 'does not delegate to a semaphore generator' do
expect(invoked_generators).not_to include(a_string_matching(/semaphore/))
end
end