feat(browse): show files in the Explorer as view-only rows - #673
Open
RonenMars wants to merge 1 commit into
Open
feat(browse): show files in the Explorer as view-only rows#673RonenMars wants to merge 1 commit into
RonenMars wants to merge 1 commit into
Conversation
The browse Explorer only listed directories, so files in a folder were invisible even though a user often needs to see them before starting a session. Render files below directories as plain, non-interactive rows — no press handler, no chevron, dimmed text — while directories stay tappable for navigation. `BrowseResponse.files` is optional, so the screen degrades to directories-only against a server that does not send files yet. Swap the folder emoji for the Phosphor Folder and File icons to match the project icon convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The browse Explorer only listed directories, so files in a folder were invisible even though a user often needs to see them before starting a session.
Files now render below directories as plain, non-interactive rows — no press handler, no chevron, dimmed text — while directories stay tappable for navigation.
Details
BrowseResponse.filesis optional, so the screen degrades to directories-only against a server that does not send files yet.Directories are listed first, then files, both already server-sorted.
The folder emoji is replaced with the Phosphor
FolderandFileicons to match the project icon convention.Depends on
Server support for the
filesfield: RonenMars/threadbase-streamer#546.Backward-compatible either way — this PR is safe to merge independently, it just shows no files until the server ships them.
Tests
New
__tests__/integration/components/BrowseFiles.test.tsx— files render, directories navigate, files do not.New suite 3/3; the 4 existing browse suites stay green (17/17);
tscandeslintclean.