docs: correct the stale CI-coverage claims in the handoff prompts [skip-ci] - #532
Open
RonenMars wants to merge 1 commit into
Open
docs: correct the stale CI-coverage claims in the handoff prompts [skip-ci]#532RonenMars wants to merge 1 commit into
RonenMars wants to merge 1 commit into
Conversation
…ip-ci] Three root-level handoff prompts carried a "do not re-derive" block asserting that the macOS and Windows CI runners ran only `npm run test:smoke` and were `continue-on-error: true`, informational and never a merge gate. Every clause of that was false: `continue-on-error` was removed on 2026-08-01, both contexts are required checks in ruleset 17561930, and since #527 both legs run the whole suite via `npm test` on a per-OS Node pin. The framing is the actual hazard rather than the individual facts. "Already established, do not re-derive" instructs the next reader to trust the paragraph without checking it, so a stale fact in that block propagates instead of being caught, which is the same failure mode that let #523 merge green. PROMPT-windows-smoke-gate.md gets a DONE banner because the task it asks for was completed on 2026-08-01 and running it again would re-do finished work. Its "facts already established" section also claimed `main` has no branch protection, citing a `branches/main/protection` 404 — that endpoint returns 404 on ruleset-protected repos, so the probe proved nothing and the conclusion invited pushing straight to `main`. Original text is struck through rather than deleted so the record of what was believed, and when, survives alongside the correction. Each correction points at docs/testing/cross-platform-ci.md, which is maintained, instead of restating facts that will drift again.
RonenMars
force-pushed
the
docs/stale-ci-claims
branch
from
August 11, 2026 16:30
ed4fb75 to
a42774d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Three root-level handoff prompts each carried a block of this shape:
Every clause after the first is false, and has been for a while:
continue-on-errorwas removed on 2026-08-01, so a red platform job fails the PR.Smoke (macos-latest)andSmoke (windows-latest)are required checks in ruleset17561930(9 contexts), so a red one blocks the merge outright.npm test, not an eight-file allowlist, on a per-OS Node pin (macOS 24, Windows 22 — the latter tracked in P2: Node 24 crashes six vitest workers on Windows, so the Windows CI leg cannot run the pinned Node #530).PROMPT-windows-smoke-gate.mdadditionally claimedmainhas no branch protection, citinggh api .../branches/main/protectionreturningBranch not protected.That endpoint returns 404 on repos protected by a ruleset rather than classic branch protection, so the probe proved nothing and the conclusion pointed the wrong way — toward believing
mainis pushable.Why the framing mattered more than the facts
Any doc can go stale. What makes these three different is that they say "do not re-derive" — an explicit instruction to the next reader to trust the paragraph without checking it.
A stale fact inside that block does not merely sit there; it propagates into whatever the reader does next, and it is protected from exactly the check that would catch it.
That is the same failure mode that let #523 merge green, and the same one that put a false Windows-coverage claim into
docs/ROADMAP.md.Correcting the facts without touching the framing would have left the mechanism in place.
What changed
PROMPT-windows-smoke-gate.mdgets a DONE banner. The task it asks for was completed on 2026-08-01, so the live risk is someone running a prompt that re-does finished work against facts that no longer hold.docs/testing/cross-platform-ci.md, which is maintained, rather than restating facts that will drift again.What was deliberately left alone
LANDING-integration-to-main.mdanddocs/landing/*also mentiontest:smokeand the smoke job, but in past tense about what PR #332 and PR #340 contained.Those statements are accurate history and were not touched.
Verified state
Checked 2026-08-11 against
origin/mainat68aa91b.gh api repos/RonenMars/threadbase-streamer/rulesets/17561930→ 9 required contexts, includingSmoke (macos-latest)andSmoke (windows-latest)..github/workflows/ci.yml:219→run: npm test;:191→node-version: ${{ matrix.node }}; matrix ismacos-latest/24 andwindows-latest/22.continue-on-erroranywhere in the workflow.Docs-only, so the title carries
[skip-ci].