docs(integration): ask the user whether a run includes draft PRs [skip-ci] - #550
Merged
Conversation
…p-ci] Once the set is resolved the skill now lists every draft in it and asks whether this run includes them, before the branch is cut rather than at the merge that hits one. The answer is never inferred: a PR is draft because it is unfinished, or because its author is blocked on something unrelated to the code, and those want opposite treatment. Including a draft does not require flipping it ready, since the skill merges the PR's head locally and the draft flag only gates merging on GitHub. Flipping a batch of PRs ready so an integration branch can be built is a change to their state nobody asked for. The same wording is in the tb-mobile copy of this skill, so the two stay in step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #547.
Once the set is resolved, the integration-branch skill now lists every draft PR in it and asks whether this run includes them — before the branch is cut, rather than at the merge that happens to hit one.
The answer is never inferred in either direction.
A PR is draft because it is unfinished, or because its author is blocked on something with nothing to do with the code, and those two want opposite treatment.
The answer is recorded in the log: included drafts flagged as such, declined ones in the exclusions table as "draft — user declined".
Including a draft does not require flipping it ready.
The skill merges the PR's head locally and GitHub's draft flag only gates merging on GitHub, so the flag is left alone — flipping a batch of PRs ready in order to build an integration branch is a change to their state nobody asked for.
The identical wording is in the tb-mobile copy of this skill (RonenMars/threadbase-mobile#675), so the two repos stay in step.