feat(i18n): ship the visitor form in all seven supported languages - #41
Merged
Conversation
199 visitor-facing strings translated into de, es, fr, hi, pt, ru and tr: form labels, help text, section headings, form titles, buttons, consent and error messages. Domain vocabulary that practitioners use untranslated stays transliterated (ayanamsa, nakshatra, panchang, kundli, gun milan, dosha). Bundled rather than waiting on wordpress.org, which is the documented on-ramp: shipped .mo files are imported into translate.wordpress.org to seed the project, and once a locale reaches the language-pack threshold the bundled copies can be removed. They load with no load_plugin_textdomain() call, verified on a real render with nothing in wp-content/languages. Ships .po (editable source), .mo, and .l10n.php (the WP 6.5+ format that avoids parsing .mo on every request). phpcs excludes languages/ for the same reason it excludes src/Generated: the .l10n.php files are emitted, not authored. Verified end to end in a live WordPress across all seven locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
199 visitor-facing strings translated into de, es, fr, hi, pt, ru, tr: form labels, help text, section headings, form titles, buttons, consent and error messages.
Domain vocabulary practitioners use untranslated stays transliterated (ayanamsa, nakshatra, panchang, kundli, gun milan, dosha), matching the convention already in the codebase.
Why bundled rather than waiting for wordpress.org
This is the documented on-ramp, not a shortcut. Per the wp.org meta handbook: shipped
.mofiles are imported into translate.wordpress.org to seed the project, language packs generate once a locale reaches 90%, and at that point the bundled copies can be removed. Verified on a real render that they load with noload_plugin_textdomain()call and nothing inwp-content/languages.Verified live, all seven
Quality checks
%s/%1$scounts must match the source or the build fails.l'ayanamsa,d'une,J'accepte) after an early pass stripped them, which is a grammar error rather than a style choice.ele alma(reads as "do not handle") toyok say.Formats
Ships
.po(editable source),.mo, and.l10n.php(the WP 6.5+ format that avoids parsing.moper request).phpcsnow excludeslanguages/for the same reason it excludessrc/Generated: those files are emitted, not authored.