Redesign: header, mascot, home layout, and CSS - #18
Conversation
✅ Deploy Preview for sbomit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Keep Hugo builds on a current Node for hugo-extended, and normalize line endings plus local/tooling ignore rules. Signed-off-by: Moo4president <munirmedia22@gmail.com>
Supersede the overlapping SBOMit#14 homepage/about messaging with the equation homepage, Community/Getting Started/FAQ/Legal nav, and related English pages. Signed-off-by: Moo4president <munirmedia22@gmail.com>
Replace the SBOMit#14 list/home presentation with sticky header, floating mascot, equation home layout, footer socials, and updated PaperMod/hugo-extended pins. Signed-off-by: Moo4president <munirmedia22@gmail.com>
bed1359 to
28f82c6
Compare
stupendoussuperpowers
left a comment
stupendoussuperpowers
left a comment
There was a problem hiding this comment.
The changes look good to me overall!
Left a few comments on things that might need changing.
| gap: 1rem; | ||
| padding: 2rem var(--gap) 1.25rem; | ||
| margin: 0 auto; | ||
| max-width: calc(var(--main-width) + var(--gap) * 2); |
There was a problem hiding this comment.
This width is too narrow (specifically because the titles on the two column layout for articles and videos get aggressively wrapped). Maybe using something like 900px or --nav-width might be better?
There was a problem hiding this comment.
Can you please give a visual of how it looks on your end? I want to see your perspective so that I can change it right.
| gap: 2.5rem; | ||
| max-width: calc(var(--nav-width) + var(--gap) * 2); | ||
| margin: 0 auto 2rem; | ||
| padding: 0 var(--gap); |
There was a problem hiding this comment.
Should remove this padding since it makes the title of home and media unaligned with the main SBOMit title at the top.
There was a problem hiding this comment.
This was intentional. The design choice was to avoid alignment with the header.
| @@ -1,60 +1,12 @@ | |||
| --- | |||
| title: "SBOMit" | |||
| title: "SBOMit = SBOM + in-toto" | |||
There was a problem hiding this comment.
I like the SBOM + in-toto header, the rest of the paragraph can probably be workshopped better. It's also taking up a lot of screen space right now without really conveying much.
Maybe something like [Catchy Two Liners] [Paragraph Break] [A proper paragraph of text describing what the project is, motivation, and where on the site to go to next etc.] :
"SBOMs tell you what's in your software. SBOMit makes sure they're accurate and trustworthy.
<br/>
SBOMit is ... It adds ... This ensures ...
Get Started by ..."
There was a problem hiding this comment.
That was intentional. The first page is meant to give visitors a quick sense of the project and direct them to Get Started.
For anyone looking for a deeper explanation of the purpose, approach, and technical details, the manifesto is available from there.
| url: https://witness.dev | ||
| weight: 5 | ||
| - identifier: manifesto | ||
| name: Manifesto |
There was a problem hiding this comment.
This should still be called Specification
There was a problem hiding this comment.
This was an intentional change. The naming "specification" here is confusing if we don't see a specification until we goes 3 layers deep with this link.
https://github.com/SBOMit/specification/blob/main/specification.md
|
Hey Mo thanks for splitting the PRs. Right now #17/#18/#19 show diffs that include all the changes from the PRs before them because their base branches point to main instead of the previous PR's branch. This makes it hard to tell what's actually new in each one. Could you either:
Whatever is easier for you, I just want to make sure we're reviewing what's new in each PR and not re-reviewing. Even on this PR, I see @stupendoussuperpowers left comments on context added in the previous PR for example |
3 participants
Summary
hugo-extendedfor the new chrome.Stack
This is PR 3/4. Includes UX + content commits until those merge. Merge order: UX → content → this → i18n.
Test plan