Skip to content

KabokuriFire first pass - #1981

Merged
ThatNintendoNerd merged 4 commits into
SMGCommunity:masterfrom
ThePlayerRolo:KabokuriFire
Aug 17, 2026
Merged

KabokuriFire first pass#1981
ThatNintendoNerd merged 4 commits into
SMGCommunity:masterfrom
ThePlayerRolo:KabokuriFire

Conversation

@ThePlayerRolo

Copy link
Copy Markdown
Contributor

No description provided.

@decomp-dev

decomp-dev Bot commented Aug 17, 2026

Copy link
Copy Markdown

Report for RMGK01 (634a697 - 24d4a9a)

📈 Matched code: 65.82% (+0.02%, +824 bytes)
📈 Matched data: 30.83% (+0.01%, +236 bytes)

✅ 15 new matches
Unit Item Bytes Before After
main/Game/Enemy/KabokuriFire .data +208 0.00% 100.00%
main/Game/Enemy/KabokuriFire KabokuriFire::init(const JMapInfoIter&) +184 0.00% 100.00%
main/Game/Enemy/KabokuriFire KabokuriFire::start(const JGeometry::TVec3<float>&, bool) +168 0.00% 100.00%
main/Game/Enemy/KabokuriFire KabokuriFire::exeWait() +144 0.00% 100.00%
main/Game/Enemy/KabokuriFire KabokuriFire::receiveOtherMsg(unsigned long, HitSensor*, HitSensor*) +124 0.00% 100.00%
main/Game/Enemy/KabokuriFire KabokuriFire::~KabokuriFire() +92 0.00% 100.00%
main/Game/Enemy/KabokuriFire KabokuriFire::KabokuriFire(const char*) +68 0.00% 100.00%
main/Game/Enemy/KabokuriFire .sdata2 +16 0.00% 100.00%
main/Game/Enemy/KabokuriFire NrvKabokuriFire::KabokuriFireNrvWait::KabokuriFireNrvWait() +16 0.00% 100.00%
main/Game/Enemy/KabokuriFire .sbss +8 0.00% 100.00%
main/Game/Enemy/KabokuriFire __sinit_\KabokuriFire_cpp +8 0.00% 100.00%
main/Game/Enemy/KabokuriFire NrvKabokuriFire::KabokuriFireNrvWait::execute(Spine*) const +8 0.00% 100.00%
main/Game/Enemy/KabokuriFire KabokuriFire::getBaseMtx() const +8 0.00% 100.00%
main/Game/Enemy/KabokuriFire .ctors +4 0.00% 100.00%
main/Game/Enemy/KabokuriFire KabokuriFire::control() +4 0.00% 100.00%
📈 2 improvements in unmatched items
Unit Item Bytes Before After
main/Game/Enemy/KabokuriFire KabokuriFire::attackSensor(HitSensor*, HitSensor*) +7 0.00% 21.67%
main/Game/Enemy/Kabokuri .data 0 20.34% 23.38%

Comment thread include/Game/Enemy/KabokuriFire.hpp
Comment thread include/Game/Enemy/KabokuriFire.hpp
Comment thread src/Game/Enemy/KabokuriFire.cpp Outdated
Comment thread src/Game/Enemy/KabokuriFire.cpp Outdated
Comment thread src/Game/Enemy/KabokuriFire.cpp Outdated
Comment thread include/Game/Enemy/KabokuriFire.hpp Outdated
@ThePlayerRolo

Copy link
Copy Markdown
Contributor Author

all comments should be addressed

Comment thread src/Game/Enemy/KabokuriFire.cpp Outdated
Comment thread src/Game/Enemy/KabokuriFire.cpp Outdated
@ThePlayerRolo

Copy link
Copy Markdown
Contributor Author

should be good now

@ThatNintendoNerd
ThatNintendoNerd merged commit 80f8947 into SMGCommunity:master Aug 17, 2026
1 check passed
@ThePlayerRolo
ThePlayerRolo deleted the KabokuriFire branch August 17, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants