Skip to content

Fix checksum status reset bug preventing unnecessary recalculation on restart #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkProminic merged 1 commit into from
Sep 25, 2025
Merged

Fix checksum status reset bug preventing unnecessary recalculation on restart #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 33 additions & 4 deletions services/fileWatcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,23 +525,52 @@ class FileWatcherService {
const isDirectory = stats ? stats.isDirectory() : false;

const File = getFileModel();

const existingFile = await File.findOne({
where: { file_path: itemPath },
raw: true,
});

const [, created] = await File.upsert({
file_path: itemPath,
file_size: stats ? stats.size : 0,
last_modified: stats ? stats.mtime : new Date(),
is_directory: isDirectory,
checksum_status: isDirectory ? 'complete' : 'pending',
checksum_status: isDirectory ? 'complete' : existingFile?.checksum_status || 'pending',
});

// Only queue checksum if:
// 1. It's a new file (created = true)
// 2. File changed (different size or mtime)
// 3. Checksum failed before (status = 'error' or 'pending')
// 4. No existing checksum
if (!isDirectory) {
// Queue checksum generation instead of doing it immediately
this.queueChecksumGeneration(itemPath);
const needsChecksum =
created ||
!existingFile ||
!existingFile.checksum_sha256 ||
existingFile.checksum_status === 'error' ||
existingFile.checksum_status === 'pending' ||
existingFile.file_size !== (stats ? stats.size : 0) ||
new Date(existingFile.last_modified).getTime() !== (stats ? stats.mtime.getTime() : 0);

if (needsChecksum) {
this.queueChecksumGeneration(itemPath);
logger.info(
`${created ? 'Created' : 'Updated'} database record: ${itemPath} (using chokidar stats, checksum queued)`
);
return { created, itemPath, skipped: false };
}
logger.info(
`${created ? 'Created' : 'Updated'} database record: ${itemPath} (using chokidar stats, checksum valid, skipped)`
);
return { created, itemPath, skipped: true };
}

logger.info(
`${created ? 'Created' : 'Updated'} database record: ${itemPath} (using chokidar stats)`
);
return { created, itemPath };
return { created, itemPath, skipped: false };
} catch (error) {
logger.error(`Error updating database for ${dirPath}/${itemName}: ${error.message}`);
// Fallback to regular method if stats-based method fails
Expand Down
Loading