Skip to content

Fix undefined rows logging issue in checksum processing - #31

Merged
MarkProminic merged 3 commits into
mainfrom
devin/1727257237-fix-undefined-rows-logging
Sep 25, 2025
Merged

MarkProminic merged 3 commits into
mainfrom
devin/1727257237-fix-undefined-rows-logging

Conversation

@devin-ai-integration

Copy link
Copy Markdown

Fix undefined rows logging issue in checksum processing

Summary

Resolves a minor logging bug where database update operations in checksum processing were logging "(undefined rows)" instead of the actual number of affected rows. The issue was caused by incorrectly accessing updateResult[0] when the actual affected row count is in updateResult[1] for Sequelize update operations.

Root Cause: Sequelize update results return [null, affectedRowCount] but the code was accessing index 0 instead of index 1.

Fix: Use array destructuring to properly extract the affected rows count from the update result.

Review & Testing Checklist for Human

  • Verify logs now show actual row counts (e.g., "Database updated with checksum for: /path/to/file (1 rows)") instead of "(undefined rows)"
  • Test checksum processing functionality to ensure the fix doesn't break core operations
  • Monitor production logs after deployment to confirm the fix works across different scenarios

Notes

devin-ai-integration Bot and others added 3 commits September 25, 2025 09:55
Co-Authored-By: mark.gilbert@prominic.net <mark.gilbert@prominic.net>
Co-Authored-By: mark.gilbert@prominic.net <mark.gilbert@prominic.net>
Co-Authored-By: mark.gilbert@prominic.net <mark.gilbert@prominic.net>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@MarkProminic
MarkProminic merged commit 28e71f0 into main Sep 25, 2025
1 of 4 checks passed
@MarkProminic
MarkProminic deleted the devin/1727257237-fix-undefined-rows-logging branch September 25, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant