Fix undefined rows logging issue in checksum processing - #31
Merged
Merged
Conversation
Co-Authored-By: mark.gilbert@prominic.net <mark.gilbert@prominic.net>
Co-Authored-By: mark.gilbert@prominic.net <mark.gilbert@prominic.net>
Co-Authored-By: mark.gilbert@prominic.net <mark.gilbert@prominic.net>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
MarkProminic
deleted the
devin/1727257237-fix-undefined-rows-logging
branch
September 25, 2025 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix undefined rows logging issue in checksum processing
Summary
Resolves a minor logging bug where database update operations in checksum processing were logging "(undefined rows)" instead of the actual number of affected rows. The issue was caused by incorrectly accessing
updateResult[0]when the actual affected row count is inupdateResult[1]for Sequelize update operations.Root Cause: Sequelize update results return
[null, affectedRowCount]but the code was accessing index 0 instead of index 1.Fix: Use array destructuring to properly extract the affected rows count from the update result.
Review & Testing Checklist for Human
Notes