Skip to content

Potential fix for code scanning alert no. 24: Server-side URL redirect #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkProminic merged 1 commit into from
Oct 1, 2025
Merged

Potential fix for code scanning alert no. 24: Server-side URL redirect #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion routes/fileServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,19 @@ router.post('*splat', (req, res, next) => {
} else if (req.query.action === 'create-folder') {
const newPath = `${req.path}/folders`;

if (!isLocalUrl(newPath)) {
// Only allow strictly relative paths, no path traversal, not protocol-relative, not external host
function isSafeRelativePath(path) {
// must start with a single "/"
if (typeof path !== 'string' || !path.startsWith('/')) return false;
// must not contain "//"
if (path.includes('//')) return false;
// must not contain ".."
if (path.includes('..')) return false;
// optional: restrict to allowed base directory/prefix
return true;
}

if (!isSafeRelativePath(newPath)) {
logger.warn('Rejected potentially unsafe redirect', { path: newPath });
return res.status(400).send('Invalid redirect path');
}
Expand Down