test(skills): skip non-UTF8 filename test on macOS - #463
Merged
Merged
Conversation
Owner
|
LGTM, THANKS!! |
Contributor
Author
|
Thank you! Here is another minimal bug fix / 另一个小小的 bug 修复: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR(zh_cn): 这个 test 不能在macos上正常运行，因为 macos 根本不支持这样的文件名
Problem
migration_tree_hash_preserves_non_utf8_namescreates filenames containing invalid UTF-8 bytes withOsStringExt.In a Nix sandbox on Darwin, creating these test fixtures fails with
EILSEQbefore the migration hash logic is exercised. The test is useful on Unix platforms that support these filenames, but the fixture is not portable to macOS.Change
Run the test on Unix except macOS:
#[cfg(all(unix, not(target_os = "macos")))]No production code changes.