vtkExtractCellType no longer compiles

[scottwittenburg]

With the VTK committed to the latest ParaView, vtkExtractCellType no longer compiles.

Compiler errors

FAILED: plugin/MEDReaderIO/CMakeFiles/MEDReaderIO.dir/vtkExtractCellType.cxx.o
/builds/gitlab-kitware-sciviz-ci/.gitlab/shortcuts/g++ -DDIY_HAS_MPI=1 -DDIY_NO_THREADS -DFMT_SHARED -DH5_BUILT_AS_DYNAMIC_LIB -DH5_USE_16_API -DMEDREADER_USE_MPI -DMPICH_SKIP_MPICXX -DMPI_NO_CPPBIND -DOMPI_SKIP_MPICXX -DPCLINUX64 -DSCN_DISABLE_FAST_FLOAT=0 -DSCN_DISABLE_REGEX=0 -DSCN_REGEX_BACKEND=0 -DVTK_MODULE_ENABLE_VTK_FiltersParallelGeometry=1 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -D_MPICC_H -D_POSIX_C_SOURCE=200809L -Dkiss_fft_scalar=double -DvtkFiltersCore_AUTOINIT_INCLUDE=\"/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/build/CMakeFiles/vtkModuleAutoInit_6ca5b28a7a867bffd27112bc34853d56.h\" -DvtkFiltersParallel_AUTOINIT_INCLUDE=\"/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/build/CMakeFiles/vtkModuleAutoInit_6ca5b28a7a867bffd27112bc34853d56.h\" -I/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/build/plugin/MEDReaderIO -I/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO -I/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/../MEDLoaderForPV -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1 -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkfmt -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtknlohmannjson/include -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtknlohmannjson -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkscn/include -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkscn -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/token -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkkissfft -fPIC -fno-operator-names -O3 -DNDEBUG -std=gnu++17 -fPIC -pthread -fopenmp -MD -MT plugin/MEDReaderIO/CMakeFiles/MEDReaderIO.dir/vtkExtractCellType.cxx.o -MF plugin/MEDReaderIO/CMakeFiles/MEDReaderIO.dir/vtkExtractCellType.cxx.o.d -o plugin/MEDReaderIO/CMakeFiles/MEDReaderIO.dir/vtkExtractCellType.cxx.o -c /builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/vtkExtractCellType.cxx
/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/vtkExtractCellType.cxx: In member function 'void vtkExtractCellType::AppendToGeoTypes(vtkDataSet*)':
/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/vtkExtractCellType.cxx:32:42: error: 'GetClassNameFromTypeId' is not a member of 'vtkCellTypes'
   32 |     const char* cellType = vtkCellTypes::GetClassNameFromTypeId(cell->GetCellType());
      |                                          ^~~~~~~~~~~~~~~~~~~~~~
/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/vtkExtractCellType.cxx: In member function 'void vtkExtractCellType::SelectIds(vtkDataSet*, vtkIdTypeArray*)':
/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/vtkExtractCellType.cxx:48:42: error: 'GetClassNameFromTypeId' is not a member of 'vtkCellTypes'
   48 |     const char* cellType = vtkCellTypes::GetClassNameFromTypeId(cell->GetCellType());
      |                                          ^~~~~~~~~~~~~~~~~~~~~~
[14/100] Generating the wrap hierarchy for MEDReaderIO
[15/100] Building CXX object plugin/MEDReaderIO/CMakeFiles/MEDReaderIO.dir/vtkPVMetaDataInformation.cxx.o
[16/100] Building CXX object plugin/MEDLoaderForPV/CMakeFiles/MEDLoaderForPV.dir/ExtractGroupHelper.cxx.o
[17/100] Building CXX object plugin/MEDReaderIO/CMakeFiles/MEDReaderIO.dir/vtkMEDQuadraturePointsGenerator.cxx.o
[18/100] Building CXX object plugin/MEDReaderIO/CMakeFiles/MEDReaderIO.dir/vtkExtractGroup.cxx.o
[19/100] Building CXX object plugin/MEDLoaderForPV/CMakeFiles/MEDLoaderForPV.dir/MEDFileFieldRepresentationTree.cxx.o
FAILED: plugin/MEDLoaderForPV/CMakeFiles/MEDLoaderForPV.dir/MEDFileFieldRepresentationTree.cxx.o
/builds/gitlab-kitware-sciviz-ci/.gitlab/shortcuts/g++ -DFMT_SHARED -DH5_BUILT_AS_DYNAMIC_LIB -DH5_USE_16_API -DMEDLoaderForPV_EXPORTS -DMEDREADER_USE_MPI -DPCLINUX64 -DSCN_DISABLE_FAST_FLOAT=0 -DSCN_DISABLE_REGEX=0 -DSCN_REGEX_BACKEND=0 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -D_POSIX_C_SOURCE=200809L -Dkiss_fft_scalar=double -I/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDLoaderForPV/. -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1 -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkfmt -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtknlohmannjson/include -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtknlohmannjson -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkscn/include -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkscn -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/token -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkkissfft -fPIC -fno-operator-names -O3 -DNDEBUG -std=gnu++17 -fPIC -pthread -fopenmp -MD -MT plugin/MEDLoaderForPV/CMakeFiles/MEDLoaderForPV.dir/MEDFileFieldRepresentationTree.cxx.o -MF plugin/MEDLoaderForPV/CMakeFiles/MEDLoaderForPV.dir/MEDFileFieldRepresentationTree.cxx.o.d -o plugin/MEDLoaderForPV/CMakeFiles/MEDLoaderForPV.dir/MEDFileFieldRepresentationTree.cxx.o -c /builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDLoaderForPV/MEDFileFieldRepresentationTree.cxx
/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDLoaderForPV/MEDFileFieldRepresentationTree.cxx: In member function 'vtkUnstructuredGrid* MEDFileFieldRepresentationLeaves::buildVTKInstanceNoTimeInterpolationUnstructured(MEDCoupling::MEDUMeshMultiLev*) const':
/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDLoaderForPV/MEDFileFieldRepresentationTree.cxx:749:10: error: 'class vtkCellArray' has no member named 'SetCells'
  749 |   cells->SetCells(nbOfCells,cells2);
      |          ^~~~~~~~
FAILED: plugin/MEDReaderIO/CMakeFiles/MEDReaderIO.dir/vtkUgSelectCellIds.cxx.o
/builds/gitlab-kitware-sciviz-ci/.gitlab/shortcuts/g++ -DDIY_HAS_MPI=1 -DDIY_NO_THREADS -DFMT_SHARED -DH5_BUILT_AS_DYNAMIC_LIB -DH5_USE_16_API -DMEDREADER_USE_MPI -DMPICH_SKIP_MPICXX -DMPI_NO_CPPBIND -DOMPI_SKIP_MPICXX -DPCLINUX64 -DSCN_DISABLE_FAST_FLOAT=0 -DSCN_DISABLE_REGEX=0 -DSCN_REGEX_BACKEND=0 -DVTK_MODULE_ENABLE_VTK_FiltersParallelGeometry=1 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -D_MPICC_H -D_POSIX_C_SOURCE=200809L -Dkiss_fft_scalar=double -DvtkFiltersCore_AUTOINIT_INCLUDE=\"/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/build/CMakeFiles/vtkModuleAutoInit_6ca5b28a7a867bffd27112bc34853d56.h\" -DvtkFiltersParallel_AUTOINIT_INCLUDE=\"/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/build/CMakeFiles/vtkModuleAutoInit_6ca5b28a7a867bffd27112bc34853d56.h\" -I/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/build/plugin/MEDReaderIO -I/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO -I/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/../MEDLoaderForPV -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1 -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkfmt -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtknlohmannjson/include -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtknlohmannjson -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkscn/include -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkscn -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/token -isystem /builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkkissfft -fPIC -fno-operator-names -O3 -DNDEBUG -std=gnu++17 -fPIC -pthread -fopenmp -MD -MT plugin/MEDReaderIO/CMakeFiles/MEDReaderIO.dir/vtkUgSelectCellIds.cxx.o -MF plugin/MEDReaderIO/CMakeFiles/MEDReaderIO.dir/vtkUgSelectCellIds.cxx.o.d -o plugin/MEDReaderIO/CMakeFiles/MEDReaderIO.dir/vtkUgSelectCellIds.cxx.o -c /builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/vtkUgSelectCellIds.cxx
/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/vtkUgSelectCellIds.cxx: In member function 'virtual int vtkUgSelectCellIds::RequestData(vtkInformation*, vtkInformationVector**, vtkInformationVector*)':
/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/vtkUgSelectCellIds.cxx:123:17: error: 'class vtkCellArray' has no member named 'SetCells'
  123 |   outCellArray->SetCells(outputNbCells,outNodalConn);
      |                 ^~~~~~~~
/builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/vtkUgSelectCellIds.cxx:124:62: error: no matching function for call to 'vtkUnstructuredGrid::SetCells(vtkNew<vtkUnsignedCharArray>&, vtkNew<vtkIdTypeArray>&, vtkNew<vtkCellArray>&)'
  124 |   output->SetCells(outCellTypes,outCellLocations,outCellArray);
      |                                                              ^
In file included from /builds/gitlab-kitware-sciviz-ci/build/superbuild/medreader/src/plugin/MEDReaderIO/vtkUgSelectCellIds.cxx:24:
/builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkUnstructuredGrid.h:258:8: note: candidate: 'void vtkUnstructuredGrid::SetCells(int, vtkCellArray*)'
  258 |   void SetCells(int type, vtkCellArray* cells);
      |        ^~~~~~~~
/builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkUnstructuredGrid.h:258:8: note:   candidate expects 2 arguments, 3 provided
/builds/gitlab-kitware-sciviz-ci/build/install/include/paraview-6.1/vtkUnstructuredGrid.h:271:8: note: candidate: 'void vtkUnstructuredGrid::SetCells(int*, vtkCellArray*)'
  271 |   void SetCells(int* types, vtkCellArray* cells);

In order to continue providing nighty ParaView binaries, paraview/paraView-superbuild must disable this plugin until the issue is fixed.

[mathstuf]

See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/12187 and https://gitlab.kitware.com/vtk/vtk/-/merge_requests/12455 for the API changes