Fix LTS develop_sources for URL+rev [sources] - #136
Merged
ChrisRackauckas merged 1 commit intoSep 9, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
On Julia 1.10, Pkg.develop rejects rev ("consider using add instead"), which
broke LTS CI for packages temporarily pinning unreleased upstreams via
[sources] URL (e.g. JumpProcesses → DiffEqBase monorepo branch).
Co-authored-by: Cursor <cursoragent@cursor.com>
ChrisRackauckas-Claude
pushed a commit
to ChrisRackauckas-Claude/JumpProcesses.jl
that referenced
this pull request
Sep 9, 2026
Julia 1.10 Pkg.develop rejects rev; SciML/.github#136 switches URL sources to Pkg.add. Until that lands (and v1 is updated), keep Jump-local Int fixes without the DiffEqBase monorepo pin — VR callback x86 still needs ODE#4487. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
Unblocks LTS CI for temporary URL |
2 tasks
2 tasks
ChrisRackauckas
added a commit
to SciML/JumpProcesses.jl
that referenced
this pull request
Sep 9, 2026
* Compare ExtendedJumpArray jump_u eltype to Int, not Int64. Broadcast of UnitRange indices yields native Int on each word size. Co-authored-by: Cursor <cursoragent@cursor.com> * Pass native-UInt salt to hash in _derive_jump_seed on 32-bit. hash(::UInt64, ::UInt64) is not defined on i686; salt with % UInt. Co-authored-by: Cursor <cursoragent@cursor.com> * Use native Int in PriorityTimeTable construction on 32-bit. floor(Int64, …) made F=Int64 while pidtogroup/kwargs used Int (Int32 on i686), so PriorityTimeTable construction MethodError'd. Co-authored-by: Cursor <cursoragent@cursor.com> * chore: retest PriorityTimeTable Int fix on x86 Co-authored-by: Cursor <cursoragent@cursor.com> * Temporarily source DiffEqBase from 32-bit interp_points fix for CI. Co-authored-by: Cursor <cursoragent@cursor.com> * Drop temporary DiffEqBase [sources] pin (breaks LTS develop). Julia 1.10 Pkg.develop rejects rev; SciML/.github#136 switches URL sources to Pkg.add. Until that lands (and v1 is updated), keep Jump-local Int fixes without the DiffEqBase monorepo pin — VR callback x86 still needs ODE#4487. Co-authored-by: Cursor <cursoragent@cursor.com> * Retest x86 after DiffEqBase 7.21.0 registration. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pkg.developrejectsrev(rev argument not supported by develop; consider using add instead).develop_sourcesnowPkg.develops localpath =sources andPkg.adds giturl =sources (withrev/subdir).[sources]pins used while landing 32-bit fixes (JumpProcesses DiffEqBase, Sundials downstreams, Groebner, PolyChaos, etc.).Test plan
julia --project=test -e 'include("test/runtests.jl")'(all pass, including newpartition_source_specsassertions)Pkg.develop(...; rev=...)fails andPkg.add(...; rev=..., subdir=...)installs DiffEqBase from the ODE monorepo branchMade with Cursor