Avoid quadratic allocation when collecting reactions and equations from subsystems - #1557
Merged
Merged
Conversation
ChrisRackauckas
approved these changes
Sep 12, 2026
Member
|
Thanks! I assume the QA test failures are unrelated, so we can merge once the doc build passes. |
Member
|
Yeah that's a blanket reexport thing. Let me change that up so we're not just reexporting everything. I think the tests look fine from this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
inittoreduce(vcat, xs)inreactions(network)andMT.equations(::ReactionSystem)opts out of the optimisedreducedispatch, resulting in quadratic allocation when dealing with hiearchical models. It is also unnecessary, as both functions return early whensystemsis empty.Example allocations (MiB) for a system with N subsystems of one reaction pair each:
reactionsmasterreactionsthis PRequationsmasterequationsthis PRChecklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.