DSL: allow dotted references in interpolated rates - #1565
Merged
TorkelE merged 1 commit intoSep 23, 2026
Merged
Conversation
A field access such as `$(sys.p)` or `Base.exp` is `Expr(:., :sys, QuoteNode(:p))`. The recursive expression walkers in the DSL (`recursive_escape_functions!`, `add_syms_from_expr!`) are dispatched on `ExprValues`, which did not include `QuoteNode`, so recursing into the field position raised a `MethodError`. Substrates and products were unaffected because they take a different path. Add `QuoteNode` to `ExprValues`. The walkers already return non-`Expr` values unchanged, so no other change is needed. Fixes SciML#1564.
isaacsas
approved these changes
Sep 23, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1564.
A field access such as
$(sys.p)orBase.expisExpr(:., :sys, QuoteNode(:p)). The recursive expression walkers in the DSL (recursive_escape_functions!,add_syms_from_expr!) are dispatched onExprValues, which did not includeQuoteNode, so recursing into the field position raised aMethodError. Substrates and products were unaffected because they take a different path.This adds
QuoteNodetoExprValues. The walkers already return non-Exprvalues unchanged, so no other change is needed. Besides the interpolation case from the issue, this also fixes module-qualified function calls in rates (k * Base.exp(-A), A --> 0), which carried the sameQuoteNode.The added test covers both, with
-->and=>arrows for the interpolated case. The three DSL test files pass locally againstmaster(dsl_basic_model_construction.jl892,dsl_advanced_model_construction.jl81,dsl_options.jl317 + 1 pre-existing broken); the new block fails with the reportedMethodErrorwithout the fix.🤖 Generated with Claude Code