Fix PeriodicCallback with Rational Δt (DE #878) - #328
Merged
ChrisRackauckas merged 2 commits intoJul 24, 2026
Merged
ChrisRackauckas merged 2 commits into
ChrisRackauckas merged 2 commits into
Conversation
Exact equality `t == t0 + index*Δt` fails when integrator time is Float64 and Δt is Rational (`Float64(3//10) == 3//10` is false). Convert period targets and tstops into the integrator's time type so Rational periods fire every step. Fixes SciML/DifferentialEquations.jl#878 Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
July 24, 2026 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PeriodicCallbackcondition used exactt == t0 + index*Δt.Δt::Rationalandt::Float64, equality is always false after t0 (Float64(3//10) == 3//10is false), so the callback never re-fires.Fixes SciML/DifferentialEquations.jl#878
This PR should be ignored until reviewed by @ChrisRackauckas.
Test plan
1//10fires ~10 times on[0,1](was 1)