Allow current SciML dependency stack in tests - #329
Merged
ChrisRackauckas merged 3 commits intoJul 28, 2026
Merged
ChrisRackauckas merged 3 commits into
ChrisRackauckas merged 3 commits into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prob_func(prob, i, repeat)call and v3's documentedprob_func(prob, ctx)call.Why
NonlinearSolve's DiffEqCallbacks downstream job failed before loading any changed NonlinearSolve code.
Pkg.test()re-resolved DiffEqCallbacks' extras and found an empty intersection between developed NonlinearSolve's ForwardDiff-1-only requirement and DiffEqCallbacks' ForwardDiff-0.10-only test compat.Fixing that first wall exposed two current-master compatibility issues behind it:
prob_func(prob, ctx), while the existing regression test only accepted the SciMLBase 2 three-argument signature. The compatibility helper preserves distinct trajectory initial values using either the old integer index or publicctx.sim_id.These are test-environment compatibility changes; package runtime dependencies are unchanged.
Investigation
upstream/master1d51c8dac(v4.23.2), proving it is independent of PR #1100's code.9f60b2e29(2025-12-27), which dropped root ForwardDiff 0.10 support; DiffEqCallbacks' 0.10-only test compat dates toc83fe3ed(2024).Local validation
Julia 1.12.6:
Testing DiffEqCallbacks tests passed).GROUP=Core: passed, including periodic tests 85/85 and saving tests 112/112.GROUP=AD: passed under ForwardDiff 1.4.2 (6/6, 16/16, and 1/1).GROUP=QA: passed (JET 15/15 and QA 21/21).--check: exit 0.git diff --check: exit 0.No test was skipped, silenced, weakened, or loosened.