Raise OrdinaryDiffEqRosenbrock test compat floor to 1.13.0 - #336
Merged
ChrisRackauckas merged 2 commits intoAug 8, 2026
Merged
ChrisRackauckas merged 2 commits into
ChrisRackauckas merged 2 commits into
Conversation
Rosenbrock below 1.13.0 imports namify from OrdinaryDiffEqCore, which only resolved while Core had 'using MacroTools'; Core 1.27.0 removed that. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
DataInterpolations 5.0.0 returns a Vector{Any} when an interpolation is
called on a range, which makes test/saving_tests.jl hit a sample MethodError.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
CI on this PR: the Downgrade lane is green — https://github.com/SciML/DiffEqCallbacks.jl/actions/runs/31258771179/job/93106207248 ( Note this took two floor bumps, both in this PR: the Please ignore until reviewed by @ChrisRackauckas. |
ChrisRackauckas
marked this pull request as ready for review
August 8, 2026 18:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
OrdinaryDiffEqRosenbrockversions below 1.13.0 doimport OrdinaryDiffEqCore: ..., namify, which only ever worked becauseOrdinaryDiffEqCoreitself hadusing MacroToolsin its module body, makingMacroTools'namifyreachable asOrdinaryDiffEqCore.namify.OrdinaryDiffEqCore1.27.0 commented that out, so those Rosenbrock versions no longer precompile against any current Core. The declared floor was1.8.0, so the Downgrade lane pins exactly the broken combination; this raises the floor to the first Rosenbrock release that importsnamifyfromMacroToolsdirectly.The lane is red on the unmodified default branch
julia-actions/julia-downgrade-compat@v2moved to30b83cf("Lock old-style test dependency floors throughPkg.test") on 2026-07-31. Before that,Pkg.testre-resolved to newest inside its own sandbox, so this lane was green while never testing the declared floors. Latest Downgrade run onmaster, failing:https://github.com/SciML/DiffEqCallbacks.jl/actions/runs/31197927448
Its
head_shaise15c274225d84f43b09a30fc8030a25be7f0b90d, which is exactly the currentmasterHEAD this PR branches from — so the red lane is on the unmodified default branch, not on stale code. The log containsPromoted old-style test dependencies into [deps] for locked Pkg.test(post-change tooling), resolvesOrdinaryDiffEqRosenbrock v1.8.0+OrdinaryDiffEqCore v1.32.0, and then:Failing before / passing after (local, Julia 1.10.11 = the lane's
lts)Reproduced by doing to
Project.tomlexactly what the action does — rewriting the[compat]entry to=<floor>— thenGROUP=Core Pkg.test():OrdinaryDiffEqRosenbrock = "=1.8.0"(the current floor), resolving Rosenbrock v1.8.0 + Core v1.36.0:OrdinaryDiffEqRosenbrock = "=1.13.0"(this PR's floor): the suite passes with nonamifyoccurrences anywhere in the log:Why 1.13.0 is minimal
Scanning every
OrdinaryDiffEqRosenbrock-v1.*tag in the OrdinaryDiffEq.jl monorepo for wherenamifyis imported from, there is exactly one transition:and the matching change on the Core side:
Confirmed against installed sources by loading each version against newest Core (1.36.0):
UndefVarError: namify not definedUndefVarError: namify not defined1.12.0 is 1.13.0's immediate predecessor and fails, so no lower floor works; the
, 2upper branch is unchanged.Not verified
Only
GROUP=Coreon Julia 1.10 was run locally, which is the group and Julia version the Downgrade lane uses. I did not run the other test groups (AD, QA), docs, or the non-downgrade CI matrix locally; the PR's own CI covers those.Please ignore until reviewed by @ChrisRackauckas.