Tighten SciMLTesting 2.4 QA coverage - #337
Merged
ChrisRackauckas merged 2 commits intoAug 9, 2026
Merged
ChrisRackauckas merged 2 commits into
ChrisRackauckas merged 2 commits into
Conversation
Raise the remaining SciMLTesting floor to 2.4 and replace private stdlib accesses with public interfaces so their QA exceptions can be removed. Add focused QR fallback coverage. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
| all_qualified_accesses_are_public = (; | ||
| ignore = ( | ||
| :QRCompactWY, # LinearAlgebra internal concrete factorization type | ||
| :RefValue, # Base internal concrete Ref type |
Member
There was a problem hiding this comment.
No please allow and use these two
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
August 9, 2026 03:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Summary
Base.RefValuefor the concrete periodic-cache storage andLinearAlgebra.QRCompactWYfor rank-check dispatch, as requested in reviewThe existing package-specific Functors extension allowlist remains because the extension imports DiffEqCallbacks-owned internal recursive-container methods from its parent package. The public API audit found all 22 package-owned exports already have definition-site docstrings, rendered documentation entries, and focused test coverage from the recently merged documentation work.
Local verification
git diff --check: passed