Import adjoint and copyto! from Base rather than LinearAlgebra - #345
Merged
ChrisRackauckas merged 1 commit intoSep 12, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
On Julia 1.13 these names are owned and publicly exported by `Base`, so ExplicitImports flags the `LinearAlgebra` import on the `via_owners` check (owner is `Base`) and the `all_explicit_imports_are_public` check (not public in LinearAlgebra). `axpy!`, `diagind`, and `mul!` remain owned by `LinearAlgebra` and are unchanged. Fixes the QA job on the `julia '1'` lane (now 1.13.0). Verified locally: `test/qa/qa.jl` passes 20/20 on Julia 1.13.0. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Devin <noreply@cognition.ai> Agent-Harness: Devin CLI 3000.10.21 Agent-Model: SWE-2 Max Agent-Session: local session, /home/crackauc/.local/share/devin/cli/sessions.db
ChrisRackauckas
added a commit
that referenced
this pull request
Sep 13, 2026
- Drop stale [compat] majors older than one year (#341) - compat: drop the unregistered SafeTestsets 1.x major (#342) - Add 32-bit Core CI lane via test_groups.toml (#343) - Add AirspeedVelocity benchmarking CI (#344) - Import `adjoint` and `copyto!` from `Base` rather than `LinearAlgebra` (#345) Agent-Harness: Claude Code Agent-Model: claude-opus-5[1m] Claude-Session: https://claude.ai/code/session_014FEzNTLFutCmTEAZ3zBg5R Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The QA job on the
julia '1'lane (Julia 1.13.0) fails two ExplicitImports checks becauseadjointandcopyto!are imported fromLinearAlgebra, while their owner isBase:all_explicit_imports_via_owners:`adjoint`/`copyto!` have owner `Base` but were imported from `LinearAlgebra`all_explicit_imports_are_public:`adjoint`/`copyto!` are not public in `LinearAlgebra`Failing run: https://github.com/SciML/DiffEqCallbacks.jl/actions/runs/34655431845
They are now imported from
Base.axpy!,diagind, andmul!are still owned byLinearAlgebraand stay in that import.Test plan
test/qa/qa.jlpasses 20/20 on Julia 1.13.0 (the two EI checks errored in CI on the unfixed code)🤖 Generated with Devin CLI 3000.10.21 (model: SWE-2 Max). Session: local session,
/home/crackauc/.local/share/devin/cli/sessions.db