DDEProblemLibrary: fix sign error in RADAR5 Oregonator (u1 equation) - #233
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
RADAR5-V2.1/OREGONATOR/dr-oregon.f has F(1) = +kM1*A*Y(2) - ..., but prob_dde_RADAR5_oregonator shared `a = -k1*A*u2 - k2*u1*v` between both components, flipping the sign of the first term in du[1]. With the wrong sign u1 decays to zero and the solution stays flat at u2 = 1e-5 instead of oscillating. Fix the RHS and docstring, add a test against the RADAR5 FCN. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Agent-Harness: Claude Code 2.1.280 Agent-Model: claude-opus-5-5[1m] Agent-Session: https://claude.ai/code/session_01Vrsu4PESdABpNaxYiTBVfd Claude-Session: https://claude.ai/code/session_01Vrsu4PESdABpNaxYiTBVfd
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
prob_dde_RADAR5_oregonatorcomputesa = -k₁*A*u[2] - k₂*u[1]*vonce and uses it in both components, sodu[1]gets-k₁ A u₂where RADAR5 has+k₁ A u₂. The RADAR5 driver (RADAR5-V2.1/OREGONATOR/dr-oregon.f, from http://www.unige.ch/~hairer/radar5-v2.1.tar) has:With the wrong sign, u₁ decays to 0 and the solution stays flat at u₂ ≈ 1e-5 on [0, 100.5], so the SciMLBenchmarks
StiffDDE/Oregonator_wpdpage compares solvers on a trivial solution. This PR fixes the RHS and the docstring, adds a Core test comparing the RHS to the RADAR5FCN, and bumps DDEProblemLibrary to 0.1.10.Verification
Before/after solution with
MethodOfSteps(Rodas5P()),reltol = 1e-9, abstol = 1e-18(DelayDiffEq 6.4.0, Julia 1.11.9),u₂sampled at t = 0:5:100:New test fails without the fix (
GROUP=Core,lib/DDEProblemLibrary, Julia 1.11):and passes with it:
GROUP=QA:Aqua | 20 20, passed. Runic--checkandtyposclean on changed files.Not verified
Julia
lts/prenot run locally (only 1.11). The problem's solution changes, so any downstream results that useprob_dde_RADAR5_oregonator(SciMLBenchmarksStiffDDE/Oregonator_wpd) change with this release.🤖 Generated with Claude Code (model: claude-opus-5-5[1m])
https://claude.ai/code/session_01Vrsu4PESdABpNaxYiTBVfd