Skip to content

fix: improve dorm label contrast - #92

Open
zeyuyaoy wants to merge 1 commit into
color-for-keyboardfrom
color-for-dorms
Open

zeyuyaoy wants to merge 1 commit into
color-for-keyboardfrom
color-for-dorms

Conversation

@zeyuyaoy

Copy link
Copy Markdown
Collaborator

No description provided.

@zeyuyaoy
zeyuyaoy added this pull request to stack #90 September 20, 2026 02:42
@zeyuyaoy
zeyuyaoy requested a review from TenType as a code owner September 20, 2026 02:42
Copilot AI lite review requested due to automatic review settings September 20, 2026 02:42
@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: dbaa1431-625c-4413-b60b-db51f2b2f7a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues remain.

Review effort: Lite
Findings: None

What changed in this PR

Improves dorm banner readability by selecting accessible text colors based on background luminance.

Changes:

  • Adds validated color and luminance utilities.
  • Applies dynamic banner background and foreground colors.
File Description
src/​utils/​bannerColors.ts Computes accessible banner foreground colors.
src/​components/​DormCard.svelte Applies computed banner colors.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants