fix: use the Grok Bot app session on Linux - #22
Merged
Conversation
🦋 Changeset detectedLatest commit: 5c77167 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux,
gbotnever found the signed-in Grok Bot app session: it only looked for the macOS descriptor path, decrypted with the macOS Keychain, and used 1003 PBKDF2 rounds. Chromium's Linux OSCrypt uses one round, stores the key in the Secret Service (v11prefix) or falls back to the fixed basic-text key (v10), and Electron keeps the descriptor under~/.config/Grok Bot/.Changes
app-session.js: platform-aware descriptor path ($XDG_CONFIG_HOME/~/.configon Linux),secret-toollookup of theGrok Botlibsecret item forv11,peanutsfor Linuxv10without touching the keyring, one PBKDF2 round on Linux. macOS behaviour and thedecryptSafeStorageString(encrypted, password)signature are unchanged.libsecret-toolsnote.Verified live on Ubuntu with Grok Bot 0.44.0 signed in:
gbot doctorreportsGrok Bot app session: usable,gbot bots list/send/threadwork with no env vars. 28/28 tests pass.