Skip to content

ci: Repair pre-commit prettier hook and pin workflow actions - #453

Merged
augustuen merged 1 commit into
Servarr:masterfrom
bakerboy448:ci/fix-precommit-pin-actions
Sep 5, 2026
Merged

ci: Repair pre-commit prettier hook and pin workflow actions#453
augustuen merged 1 commit into
Servarr:masterfrom
bakerboy448:ci/fix-precommit-pin-actions

Conversation

@bakerboy448

Copy link
Copy Markdown
Contributor

Problem

The prettier pre-commit hook points at pre-commit/mirrors-prettier, which is archived and whose last release is an alpha (v4.0.0-alpha.8). That makes the hook brittle/broken to install and impossible for Dependabot/Renovate to advance.

Changes

  • Fix the hook: migrate to the maintained rbubley/mirrors-prettier@v3.8.4. Verified locally: pre-commit run prettier --all-files passes and reformats nothing (no churn).
  • SHA-pin all GitHub Actions (with # vX.Y.Z comments) — supply-chain best practice; Dependabot continues to bump the SHAs.
  • Currency: actions/checkout v5→v6.0.3, actions/setup-node v5→v6.4.0.

No workflow logic, triggers, or steps changed. Pure CI maintenance — safe for a reviewer to merge as-is.

@bakerboy448
bakerboy448 marked this pull request as draft June 25, 2026 21:58
@bakerboy448

Copy link
Copy Markdown
Contributor Author

Will rebase and target to land after the big update PR

Migrate the prettier pre-commit hook off the archived pre-commit/mirrors-prettier (last release an alpha) to the maintained rbubley/mirrors-prettier v3.8.4. SHA-pin the checkout, setup-python, setup-node, cache, and pre-commit actions to immutable commits. Re-scoped to CI files only; the earlier doc-reformat churn is superseded by current master.
@bakerboy448
bakerboy448 force-pushed the ci/fix-precommit-pin-actions branch from a93dba0 to fa7ab92 Compare September 5, 2026 00:00
@bakerboy448
bakerboy448 marked this pull request as ready for review September 5, 2026 14:36
@augustuen
augustuen merged commit 53afd79 into Servarr:master Sep 5, 2026
2 checks passed
@bakerboy448

Copy link
Copy Markdown
Contributor Author

Ready to land. This is independent of the docs sweep in #466 (workflow/CI files vs docs pages), so the earlier rebase-after dependency is not needed. Currently mergeable against master with both checks green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants