Skip to content

fix(plugin): always emit general.properties in generated project.json - #19

Merged
ShadowNineX merged 1 commit into
mainfrom
codex/github-mention-we-crashes-if-properties-doesn-t-exist-in-pr
Sep 8, 2026
Merged

fix(plugin): always emit general.properties in generated project.json#19
ShadowNineX merged 1 commit into
mainfrom
codex/github-mention-we-crashes-if-properties-doesn-t-exist-in-pr

Conversation

@ShadowNineX

Copy link
Copy Markdown
Owner

Motivation

  • Wallpaper Engine crashes when a project.json omits the general.properties block, so the plugin must always include it (even if empty) to produce compatible output.
  • Preserve existing behavior for schemeColor, localization, and audio-processing detection while ensuring the top-level general block is consistently present.

Description

  • Initialize generated properties to {} when none are configured and always include it on the general block in generateBundle by assigning project.general = general with general created as { properties }.
  • Adjust the schemeColor preservation logic to read properties.schemecolor safely now that properties is always an object.
  • Update unit tests in packages/wallpaper-engine/tests/plugin.test.ts to expect an empty general.properties record and extend workshop preservation tests in packages/wallpaper-engine/tests/workshop.test.ts to assert the same.
  • Document the fix in CHANGELOG.md under the Unreleased section.

Testing

  • Ran bun run --filter=wallpaper-engine test:run -- tests/plugin.test.ts and all plugin tests passed (54 passed).
  • Ran the full package test suite with bun run --filter=wallpaper-engine test:run and all tests passed (301 passed).
  • Ran bun run --filter=wallpaper-engine typecheck and typechecking succeeded.
  • Ran bun run --filter=wallpaper-engine lint and the lint step failed due to an ESLint plugin runtime error (TypeError: mapTypes.union is not a function) in the environment, not related to these code changes.

Codex Task

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T02:58:36.085367Z 242af52 PR opened
🔒 Security Review Completed 2026-09-08T03:00:42.947985Z 242af52 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 1cef913b-ef98-4fd1-a799-d03d9c79e21d


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@ShadowNineX
ShadowNineX merged commit fb9d3e5 into main Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant