fix(plugin): always emit general.properties in generated project.json - #19
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |



Motivation
project.jsonomits thegeneral.propertiesblock, so the plugin must always include it (even if empty) to produce compatible output.schemeColor,localization, and audio-processing detection while ensuring the top-levelgeneralblock is consistently present.Description
propertiesto{}when none are configured and always include it on thegeneralblock ingenerateBundleby assigningproject.general = generalwithgeneralcreated as{ properties }.schemeColorpreservation logic to readproperties.schemecolorsafely now thatpropertiesis always an object.packages/wallpaper-engine/tests/plugin.test.tsto expect an emptygeneral.propertiesrecord and extend workshop preservation tests inpackages/wallpaper-engine/tests/workshop.test.tsto assert the same.CHANGELOG.mdunder the Unreleased section.Testing
bun run --filter=wallpaper-engine test:run -- tests/plugin.test.tsand all plugin tests passed (54 passed).bun run --filter=wallpaper-engine test:runand all tests passed (301 passed).bun run --filter=wallpaper-engine typecheckand typechecking succeeded.bun run --filter=wallpaper-engine lintand the lint step failed due to an ESLint plugin runtime error (TypeError: mapTypes.union is not a function) in the environment, not related to these code changes.Codex Task