test: restore permissions before removing temp dirs (fixes red CI on main) - #6
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The POSIX storage test chmods its temp app dir to 555 to simulate a read-only deployment. The per-test cleanup then failed to delete it (EACCES on rmSync), which failed the test on Linux CI even though its assertions passed. Restore 0755 before removing each temp dir. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Tests workflow on
mainfails on Linux (run 36224723422):The test's assertions pass: the server does fall back to the temp directory when its app dir is
chmod 555. The failure is in the per-test cleanup, which can't delete the read-only dir. An earlier cleanup refactor in #1 dropped the step that restored permissions. This test is skipped on Windows, which is why it wasn't caught locally.Fix
Before deleting each temp dir,
chmodit back to0755(non-Windows only). Test-only change; no runtime code touched.🤖 Generated with Claude Code