Skip to content

[Godunov] Move Euler time derivatives out of InterpolateToFace - #2325

Merged
mergify[bot] merged 1 commit into
Shamrock-code:mainfrom
tdavidcl:claude/beautiful-cannon-qx2gtv
Sep 14, 2026
Merged

mergify[bot] merged 1 commit into
Shamrock-code:mainfrom
tdavidcl:claude/beautiful-cannon-qx2gtv

Conversation

@tdavidcl

Copy link
Copy Markdown
Member

Here is a big one but for a +20% perf gain. Nice !

The face reconstruction predicts each primitive variable half a timestep
forward, and until now that predictor was evaluated inside the per-face
interpolation kernels, once for each side of every link. Since every cell
takes part in several links, each cell's dt_* was recomputed a dozen or so
times per step, and the operands feeding it - chiefly the three velocity
gradient fields - were re-fetched from global memory once per face side.
The rho and pressure interpolators read all three of them purely for that
term.

The dt_* expressions depend only on cell local quantities, so evaluate them
once per cell instead:

- NodeEulerTimeDerivativeGas   -> euler_dt_rho, euler_dt_vel, euler_dt_press
- NodeEulerTimeDerivativeDust  -> euler_dt_rho_dust, euler_dt_vel_dust

Both run in a new "Euler time derivatives" sequence between the slope
limited gradients and the face interpolation, sized on
block_counts_with_ghost so ghost cells reached through id_b are covered.

The five InterpolateToFace nodes now load the precomputed derivative and
drop the inputs that only fed it:

  Rho       keeps rho, grad_rho              drops vel, dx_v, dy_v, dz_v
  Vel       keeps vel, dx_v, dy_v, dz_v      drops rho, grad_P
  Press     keeps press, grad_P              drops vel, dx_v, dy_v, dz_v
  RhoDust   keeps rho_dust, grad_rho_dust    drops the dust velocity fields
  VelDust   keeps vel_dust and its gradients drops rho_dust

InterpolateToFacePress no longer needs gamma, so the ctor parameter is gone.
While renumbering the edge slots, the five nodes were migrated from their
hand written Edges/set_edges/get_edges to the EXPAND_NODE_EDGES macro, which
keeps the ro/rw indices in sync by construction - hand renumbering across
runs of same-typed IFieldSpan edges would bind silently wrong on a mistake.

The arithmetic is transcribed verbatim into fields of the same scalar type,
so results are unchanged. This costs 5 extra doubles per gas cell and
4 per dust species per cell.

Assisted-by: Claude Code
@github-actions

Copy link
Copy Markdown
Contributor

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label full-ci to run the full test suite (default is light CI; full CI also runs on Mergify merge-queue branches).
5 - Add label profile-build to run the compile-time build profile job even in light CI.
6 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b92239b0-8544-4cb3-a079-ea82dfbde5b2

📥 Commits

Reviewing files that changed from the base of the PR and between e54f092 and 5806c06.

📒 Files selected for processing (9)
  • src/shammodels/ramses/CMakeLists.txt
  • src/shammodels/ramses/include/shammodels/ramses/modules/EulerTimeDerivativeDust.hpp
  • src/shammodels/ramses/include/shammodels/ramses/modules/EulerTimeDerivativeGas.hpp
  • src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp
  • src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp
  • src/shammodels/ramses/src/Solver.cpp
  • src/shammodels/ramses/src/modules/EulerTimeDerivativeDust.cpp
  • src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp
  • src/shammodels/ramses/src/modules/InterpolateToFace.cpp

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The solver now computes gas and dust Euler time derivatives once per cell. It stores these derivatives in SolverStorage and passes them to gas and dust face-interpolation nodes.

Changes

Euler derivative computation

Layer / File(s) Summary
Euler derivative nodes
src/shammodels/ramses/include/shammodels/ramses/modules/EulerTimeDerivative*.hpp, src/shammodels/ramses/src/modules/EulerTimeDerivative*.cpp, src/shammodels/ramses/CMakeLists.txt
Adds gas and pressureless-dust solver-graph nodes. The nodes validate spans, compute derivatives with distributed kernels, generate TeX descriptions, and are included in the Ramses build.

Face interpolation and solver integration

Layer / File(s) Summary
Interpolation derivative inputs
src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp, src/shammodels/ramses/src/modules/InterpolateToFace.cpp
Face interpolation consumes precomputed gas and dust derivative spans. Local derivative helper calculations and obsolete inputs are removed.
Solver storage and graph wiring
src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp, src/shammodels/ramses/src/Solver.cpp
Adds five derivative fields and computes them before gas and dust face interpolation. The pressure interpolator no longer receives eos_gamma.

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Refactor

Sequence Diagram(s)

sequenceDiagram
  participant SolverGraph
  participant EulerDerivativeNodes
  participant SolverStorage
  participant FaceInterpolation
  SolverGraph->>EulerDerivativeNodes: Evaluate gas and dust gradients
  EulerDerivativeNodes->>SolverStorage: Store primitive-state derivatives
  SolverGraph->>FaceInterpolation: Pass derivative fields
  FaceInterpolation->>SolverGraph: Produce reconstructed face values
Loading

Merge Risk: ⚪ Minimal · up to 5806c

The precomputed derivative flow is wired consistently across gas and dust paths, with no concrete merge-blocking regression identified.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 43 functions across 8 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description is related to the performance objective, but it is too vague to explain the actual changes or the source of the reported performance gain. Describe that Euler time derivatives are now computed once per cell and reused by face interpolation, and state how the approximately 20% performance improvement was measured.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: moving Euler time-derivative calculations out of InterpolateToFace.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 43 functions across 8 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit 5806c06
Commiter email is timothee.davidcleris@proton.me

Light CI is enabled (the default for pull requests). This will only run the basic tests and not the full tests.
Full CI runs if the full-ci label is set, or automatically on Mergify merge-queue branches (mergify/merge-queue/*).
The merge gate job "on PR / all" is skipped in this case. Queue entry uses "on PR / all_light"; full CI runs in the merge queue.

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
cmake-format.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report

/__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/EulerTimeDerivativeGas.hpp:62:27: warning: invalid case style for member 'spans_grad_P' [readability-identifier-naming]
   62 |         EXPAND_NODE_EDGES(NODE_EDGES)
      |                           ^
/__w/Shamrock/Shamrock/src/shamsolvergraph/include/shamsolvergraph/node/INode.hpp:333:9: note: expanded from macro 'EXPAND_NODE_EDGES'
  333 |         EDGES(INODE_DECL_RO, INODE_DECL_RW)                                                        \
      |         ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/EulerTimeDerivativeGas.hpp:34:51: note: expanded from macro 'NODE_EDGES'
   34 |     X_RO(shamrock::solvergraph::IFieldSpan<Tvec>, spans_grad_P)                                    \
      |                                                   ^
/__w/Shamrock/Shamrock/src/shamsolvergraph/include/shamsolvergraph/node/INode.hpp:307:47: note: expanded from macro 'INODE_DECL_RO'
  307 | #define INODE_DECL_RO(type, name) const type &name;
      |                                               ^
note: this fix will not be applied because it overlaps with another fix
/__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/EulerTimeDerivativeGas.hpp:62:27: warning: invalid case style for parameter 'spans_grad_P' [readability-identifier-naming]
   62 |         EXPAND_NODE_EDGES(NODE_EDGES)
      |                           ^
/__w/Shamrock/Shamrock/src/shamsolvergraph/include/shamsolvergraph/node/INode.hpp:337:9: note: expanded from macro 'EXPAND_NODE_EDGES'
  337 |         EDGES(INODE_PARAM_RO, INODE_PARAM_RW) SourceLocation loc = SourceLocation{}) {             \
      |         ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/EulerTimeDerivativeGas.hpp:34:51: note: expanded from macro 'NODE_EDGES'
   34 |     X_RO(shamrock::solvergraph::IFieldSpan<Tvec>, spans_grad_P)                                    \
      |                                                   ^
/__w/Shamrock/Shamrock/src/shamsolvergraph/include/shamsolvergraph/node/INode.hpp:309:65: note: expanded from macro 'INODE_PARAM_RO'
  309 | #define INODE_PARAM_RO(type, name) const std::shared_ptr<type> &name,
      |                                                                 ^
note: this fix will not be applied because it overlaps with another fix

49223 warnings generated.
Suppressed 49221 warnings (49221 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:27:10: error: 'shammodels/ramses/GhostZoneData.hpp' file not found [clang-diagnostic-error]
   27 | #include "shammodels/ramses/GhostZoneData.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

54462 warnings and 1 error generated.
Error while processing /__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp.
Suppressed 54462 warnings (54460 in non-user code, 2 due to line filter).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler errors, but -fix-errors was not specified.
Fixes have NOT been applied.

Found compiler error(s).

/__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:191:27: warning: invalid case style for member 'spans_grad_P' [readability-identifier-naming]
  191 |         EXPAND_NODE_EDGES(NODE_EDGES_PRESS)
      |                           ^
/__w/Shamrock/Shamrock/src/shamsolvergraph/include/shamsolvergraph/node/INode.hpp:333:9: note: expanded from macro 'EXPAND_NODE_EDGES'
  333 |         EDGES(INODE_DECL_RO, INODE_DECL_RW)                                                        \
      |         ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:80:51: note: expanded from macro 'NODE_EDGES_PRESS'
   80 |     X_RO(shamrock::solvergraph::IFieldSpan<Tvec>, spans_grad_P)                                    \
      |                                                   ^
/__w/Shamrock/Shamrock/src/shamsolvergraph/include/shamsolvergraph/node/INode.hpp:307:47: note: expanded from macro 'INODE_DECL_RO'
  307 | #define INODE_DECL_RO(type, name) const type &name;
      |                                               ^
note: this fix will not be applied because it overlaps with another fix
/__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:191:27: warning: invalid case style for parameter 'spans_grad_P' [readability-identifier-naming]
  191 |         EXPAND_NODE_EDGES(NODE_EDGES_PRESS)
      |                           ^
/__w/Shamrock/Shamrock/src/shamsolvergraph/include/shamsolvergraph/node/INode.hpp:337:9: note: expanded from macro 'EXPAND_NODE_EDGES'
  337 |         EDGES(INODE_PARAM_RO, INODE_PARAM_RW) SourceLocation loc = SourceLocation{}) {             \
      |         ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:80:51: note: expanded from macro 'NODE_EDGES_PRESS'
   80 |     X_RO(shamrock::solvergraph::IFieldSpan<Tvec>, spans_grad_P)                                    \
      |                                                   ^
/__w/Shamrock/Shamrock/src/shamsolvergraph/include/shamsolvergraph/node/INode.hpp:309:65: note: expanded from macro 'INODE_PARAM_RO'
  309 | #define INODE_PARAM_RO(type, name) const std::shared_ptr<type> &name,
      |                                                                 ^
note: this fix will not be applied because it overlaps with another fix

50387 warnings generated.
Suppressed 50385 warnings (50385 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:41:18: warning: invalid case style for parameter 'spans_grad_P' [readability-identifier-naming]
   41 |                 &spans_grad_P,
      |                  ^~~~~~~~~~~~
      |                  spans_grad_p
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:41:18: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:66:21: note: FIX-IT applied suggested code changes
   66 |                     spans_grad_P},
      |                     ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:78:44: warning: invalid case style for parameter 'grad_P' [readability-identifier-naming]
   78 |                     const Tvec *__restrict grad_P,
      |                                            ^~~~~~
      |                                            grad_p
   79 |                     Tscal *__restrict dt_rho,
   80 |                     Tvec *__restrict dt_vel,
   81 |                     Tscal *__restrict dt_press) {
   82 |                     Tscal rho_i     = rho[i];
   83 |                     Tvec v_i        = vel[i];
   84 |                     Tscal P_i       = press[i];
   85 |                     Tvec grad_rho_i = grad_rho[i];
   86 |                     Tvec dx_v_i     = dx_v[i];
   87 |                     Tvec dy_v_i     = dy_v[i];
   88 |                     Tvec dz_v_i     = dz_v[i];
   89 |                     Tvec grad_P_i   = grad_P[i];
      |                                       ~~~~~~
      |                                       grad_p
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:78:44: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:89:39: note: FIX-IT applied suggested code changes
   89 |                     Tvec grad_P_i   = grad_P[i];
      |                                       ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:84:27: warning: invalid case style for variable 'P_i' [readability-identifier-naming]
   84 |                     Tscal P_i       = press[i];
      |                           ^~~
      |                           p_i
   85 |                     Tvec grad_rho_i = grad_rho[i];
   86 |                     Tvec dx_v_i     = dx_v[i];
   87 |                     Tvec dy_v_i     = dy_v[i];
   88 |                     Tvec dz_v_i     = dz_v[i];
   89 |                     Tvec grad_P_i   = grad_P[i];
   90 | 
   91 |                     dt_rho[i] = -(
   92 |                         sham::dot(v_i, grad_rho_i) + rho_i * (dx_v_i[0] + dy_v_i[1] + dz_v_i[2]));
   93 | 
   94 |                     dt_vel[i]
   95 |                         = -(v_i[0] * dx_v_i + v_i[1] * dy_v_i + v_i[2] * dz_v_i + grad_P_i / rho_i);
   96 | 
   97 |                     dt_press[i]
   98 |                         = -(gamma * P_i * (dx_v_i[0] + dy_v_i[1] + dz_v_i[2])
      |                                     ~~~
      |                                     p_i
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:84:27: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:98:37: note: FIX-IT applied suggested code changes
   98 |                         = -(gamma * P_i * (dx_v_i[0] + dy_v_i[1] + dz_v_i[2])
      |                                     ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:89:26: warning: invalid case style for variable 'grad_P_i' [readability-identifier-naming]
   89 |                     Tvec grad_P_i   = grad_P[i];
      |                          ^~~~~~~~
      |                          grad_p_i
   90 | 
   91 |                     dt_rho[i] = -(
   92 |                         sham::dot(v_i, grad_rho_i) + rho_i * (dx_v_i[0] + dy_v_i[1] + dz_v_i[2]));
   93 | 
   94 |                     dt_vel[i]
   95 |                         = -(v_i[0] * dx_v_i + v_i[1] * dy_v_i + v_i[2] * dz_v_i + grad_P_i / rho_i);
      |                                                                                   ~~~~~~~~
      |                                                                                   grad_p_i
   96 | 
   97 |                     dt_press[i]
   98 |                         = -(gamma * P_i * (dx_v_i[0] + dy_v_i[1] + dz_v_i[2])
   99 |                             + sham::dot(v_i, grad_P_i));
      |                                              ~~~~~~~~
      |                                              grad_p_i
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:89:26: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:95:83: note: FIX-IT applied suggested code changes
   95 |                         = -(v_i[0] * dx_v_i + v_i[1] * dy_v_i + v_i[2] * dz_v_i + grad_P_i / rho_i);
      |                                                                                   ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:99:46: note: FIX-IT applied suggested code changes
   99 |                             + sham::dot(v_i, grad_P_i));
      |                                              ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:153:14: warning: invalid case style for variable 'grad_P' [readability-identifier-naming]
  153 |         auto grad_P      = get_ro_edge_base(8).get_tex_symbol();
      |              ^~~~~~
      |              grad_p
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:153:14: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp:185:48: note: FIX-IT applied suggested code changes
  185 |         shambase::replace_all(tex, "{grad_P}", grad_P);
      |                                                ^

50371 warnings generated.
clang-tidy applied 11 of 11 suggested fixes.
Suppressed 50366 warnings (50366 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:87:15: warning: invalid case style for class 'acc' [readability-identifier-naming]
   87 |         class acc {
      |               ^~~
      |               Acc
   88 |             public:
   89 |             GetShift<Tvec, TgridVec, AMRBlock> shift_get;
   90 | 
   91 |             const Tscal *acc_rho_cell;
   92 |             const Tvec *acc_grad_rho_cell;
   93 | 
   94 |             // For time interpolation
   95 |             const Tscal *acc_dt_rho_cell;
   96 | 
   97 |             Tscal dt_interp;
   98 | 
   99 |             acc(const Tvec *aabb_block_lower,
      |             ~~~
      |             Acc
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:87:15: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:99:13: note: FIX-IT applied suggested code changes
   99 |             acc(const Tvec *aabb_block_lower,
      |             ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:131:16: note: FIX-IT applied suggested code changes
  131 |         inline acc get_read_access(sham::EventList &deps) {
      |                ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:132:20: note: FIX-IT applied suggested code changes
  132 |             return acc(
      |                    ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:142:54: warning: the parameter 'e' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
  142 |         inline void complete_event_state(sycl::event e) {
      |                                                      ^
      |                                          const      &
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:142:42: note: FIX-IT applied suggested code changes
  142 |         inline void complete_event_state(sycl::event e) {
      |                                          ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:142:53: note: FIX-IT applied suggested code changes
  142 |         inline void complete_event_state(sycl::event e) {
      |                                                     ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:167:15: warning: invalid case style for class 'acc' [readability-identifier-naming]
  167 |         class acc {
      |               ^~~
      |               Acc
  168 |             public:
  169 |             GetShift<Tvec, TgridVec, AMRBlock> shift_get;
  170 | 
  171 |             const Tvec *acc_vel_cell;
  172 |             const Tvec *acc_dx_v_cell;
  173 |             const Tvec *acc_dy_v_cell;
  174 |             const Tvec *acc_dz_v_cell;
  175 | 
  176 |             // For time interpolation
  177 |             const Tvec *acc_dt_vel_cell;
  178 | 
  179 |             Tscal dt_interp;
  180 | 
  181 |             acc(const Tvec *aabb_block_lower,
      |             ~~~
      |             Acc
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:167:15: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:181:13: note: FIX-IT applied suggested code changes
  181 |             acc(const Tvec *aabb_block_lower,
      |             ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:223:16: note: FIX-IT applied suggested code changes
  223 |         inline acc get_read_access(sham::EventList &deps) {
      |                ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:224:20: note: FIX-IT applied suggested code changes
  224 |             return acc(
      |                    ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:236:54: warning: the parameter 'e' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
  236 |         inline void complete_event_state(sycl::event e) {
      |                                                      ^
      |                                          const      &
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:236:42: note: FIX-IT applied suggested code changes
  236 |         inline void complete_event_state(sycl::event e) {
      |                                          ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:236:53: note: FIX-IT applied suggested code changes
  236 |         inline void complete_event_state(sycl::event e) {
      |                                                     ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:255:51: warning: invalid case style for member 'grad_P_cell' [readability-identifier-naming]
  255 |         shamrock::PatchDataFieldSpanPointer<Tvec> grad_P_cell;
      |                                                   ^~~~~~~~~~~
      |                                                   grad_p_cell
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:255:51: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:309:17: note: FIX-IT applied suggested code changes
  309 |                 grad_P_cell.get_read_access(deps),
      |                 ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:318:13: note: FIX-IT applied suggested code changes
  318 |             grad_P_cell.complete_event_state(e);
      |             ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:258:52: warning: invalid case style for member 'dt_P_cell' [readability-identifier-naming]
  258 |         shamrock::PatchDataFieldSpanPointer<Tscal> dt_P_cell;
      |                                                    ^~~~~~~~~
      |                                                    dt_p_cell
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:258:52: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:311:17: note: FIX-IT applied suggested code changes
  311 |                 dt_P_cell.get_read_access(deps));
      |                 ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:319:13: note: FIX-IT applied suggested code changes
  319 |             dt_P_cell.complete_event_state(e);
      |             ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:260:15: warning: invalid case style for class 'acc' [readability-identifier-naming]
  260 |         class acc {
      |               ^~~
      |               Acc
  261 |             public:
  262 |             GetShift<Tvec, TgridVec, AMRBlock> shift_get;
  263 | 
  264 |             const Tscal *acc_P_cell;
  265 |             const Tvec *acc_grad_P_cell;
  266 | 
  267 |             // For time interpolation
  268 |             const Tscal *acc_dt_P_cell;
  269 | 
  270 |             Tscal dt_interp;
  271 | 
  272 |             acc(const Tvec *aabb_block_lower,
      |             ~~~
      |             Acc
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:260:15: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:272:13: note: FIX-IT applied suggested code changes
  272 |             acc(const Tvec *aabb_block_lower,
      |             ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:304:16: note: FIX-IT applied suggested code changes
  304 |         inline acc get_read_access(sham::EventList &deps) {
      |                ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:305:20: note: FIX-IT applied suggested code changes
  305 |             return acc(
      |                    ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:265:25: warning: invalid case style for member 'acc_grad_P_cell' [readability-identifier-naming]
  265 |             const Tvec *acc_grad_P_cell;
      |                         ^~~~~~~~~~~~~~~
      |                         acc_grad_p_cell
  266 | 
  267 |             // For time interpolation
  268 |             const Tscal *acc_dt_P_cell;
  269 | 
  270 |             Tscal dt_interp;
  271 | 
  272 |             acc(const Tvec *aabb_block_lower,
  273 |                 const Tscal *aabb_cell_size,
  274 |                 const Tscal *P_cell,
  275 |                 const Tvec *grad_P_cell,
  276 |                 // For time interpolation
  277 |                 Tscal dt_interp,
  278 |                 const Tscal *dt_P_cell)
  279 |                 : shift_get(aabb_block_lower, aabb_cell_size), acc_P_cell{P_cell},
  280 |                   acc_grad_P_cell{grad_P_cell}, acc_dt_P_cell{dt_P_cell}, dt_interp(dt_interp) {}
      |                   ~~~~~~~~~~~~~~~
      |                   acc_grad_p_cell
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:265:25: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:280:19: note: FIX-IT applied suggested code changes
  280 |                   acc_grad_P_cell{grad_P_cell}, acc_dt_P_cell{dt_P_cell}, dt_interp(dt_interp) {}
      |                   ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:287:33: note: FIX-IT applied suggested code changes
  287 |                 Tvec grad_P_a = acc_grad_P_cell[id_a];
      |                                 ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:289:33: note: FIX-IT applied suggested code changes
  289 |                 Tvec grad_P_b = acc_grad_P_cell[id_b];
      |                                 ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:268:26: warning: invalid case style for member 'acc_dt_P_cell' [readability-identifier-naming]
  268 |             const Tscal *acc_dt_P_cell;
      |                          ^~~~~~~~~~~~~
      |                          acc_dt_p_cell
  269 | 
  270 |             Tscal dt_interp;
  271 | 
  272 |             acc(const Tvec *aabb_block_lower,
  273 |                 const Tscal *aabb_cell_size,
  274 |                 const Tscal *P_cell,
  275 |                 const Tvec *grad_P_cell,
  276 |                 // For time interpolation
  277 |                 Tscal dt_interp,
  278 |                 const Tscal *dt_P_cell)
  279 |                 : shift_get(aabb_block_lower, aabb_cell_size), acc_P_cell{P_cell},
  280 |                   acc_grad_P_cell{grad_P_cell}, acc_dt_P_cell{dt_P_cell}, dt_interp(dt_interp) {}
      |                                                 ~~~~~~~~~~~~~
      |                                                 acc_dt_p_cell
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:268:26: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:280:49: note: FIX-IT applied suggested code changes
  280 |                   acc_grad_P_cell{grad_P_cell}, acc_dt_P_cell{dt_P_cell}, dt_interp(dt_interp) {}
      |                                                 ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:291:36: note: FIX-IT applied suggested code changes
  291 |                 Tscal dtP_cell_a = acc_dt_P_cell[id_a];
      |                                    ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:292:36: note: FIX-IT applied suggested code changes
  292 |                 Tscal dtP_cell_b = acc_dt_P_cell[id_b];
      |                                    ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:275:29: warning: invalid case style for parameter 'grad_P_cell' [readability-identifier-naming]
  275 |                 const Tvec *grad_P_cell,
      |                             ^~~~~~~~~~~
      |                             grad_p_cell
  276 |                 // For time interpolation
  277 |                 Tscal dt_interp,
  278 |                 const Tscal *dt_P_cell)
  279 |                 : shift_get(aabb_block_lower, aabb_cell_size), acc_P_cell{P_cell},
  280 |                   acc_grad_P_cell{grad_P_cell}, acc_dt_P_cell{dt_P_cell}, dt_interp(dt_interp) {}
      |                                   ~~~~~~~~~~~
      |                                   grad_p_cell
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:275:29: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:280:35: note: FIX-IT applied suggested code changes
  280 |                   acc_grad_P_cell{grad_P_cell}, acc_dt_P_cell{dt_P_cell}, dt_interp(dt_interp) {}
      |                                   ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:278:30: warning: invalid case style for parameter 'dt_P_cell' [readability-identifier-naming]
  278 |                 const Tscal *dt_P_cell)
      |                              ^~~~~~~~~
      |                              dt_p_cell
  279 |                 : shift_get(aabb_block_lower, aabb_cell_size), acc_P_cell{P_cell},
  280 |                   acc_grad_P_cell{grad_P_cell}, acc_dt_P_cell{dt_P_cell}, dt_interp(dt_interp) {}
      |                                                               ~~~~~~~~~
      |                                                               dt_p_cell
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:278:30: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:280:63: note: FIX-IT applied suggested code changes
  280 |                   acc_grad_P_cell{grad_P_cell}, acc_dt_P_cell{dt_P_cell}, dt_interp(dt_interp) {}
      |                                                               ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:288:23: warning: invalid case style for variable 'P_b' [readability-identifier-naming]
  288 |                 Tscal P_b     = acc_P_cell[id_b];
      |                       ^~~
      |                       p_b
  289 |                 Tvec grad_P_b = acc_grad_P_cell[id_b];
  290 | 
  291 |                 Tscal dtP_cell_a = acc_dt_P_cell[id_a];
  292 |                 Tscal dtP_cell_b = acc_dt_P_cell[id_b];
  293 | 
  294 |                 Tscal P_face_a = P_a + sycl::dot(grad_P_a, shift_a) + dtP_cell_a * dt_interp;
  295 |                 Tscal P_face_b = P_b + sycl::dot(grad_P_b, shift_b) + dtP_cell_b * dt_interp;
      |                                  ~~~
      |                                  p_b
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:288:23: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:295:34: note: FIX-IT applied suggested code changes
  295 |                 Tscal P_face_b = P_b + sycl::dot(grad_P_b, shift_b) + dtP_cell_b * dt_interp;
      |                                  ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:289:22: warning: invalid case style for variable 'grad_P_b' [readability-identifier-naming]
  289 |                 Tvec grad_P_b = acc_grad_P_cell[id_b];
      |                      ^~~~~~~~
      |                      grad_p_b
  290 | 
  291 |                 Tscal dtP_cell_a = acc_dt_P_cell[id_a];
  292 |                 Tscal dtP_cell_b = acc_dt_P_cell[id_b];
  293 | 
  294 |                 Tscal P_face_a = P_a + sycl::dot(grad_P_a, shift_a) + dtP_cell_a * dt_interp;
  295 |                 Tscal P_face_b = P_b + sycl::dot(grad_P_b, shift_b) + dtP_cell_b * dt_interp;
      |                                                  ~~~~~~~~
      |                                                  grad_p_b
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:289:22: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:295:50: note: FIX-IT applied suggested code changes
  295 |                 Tscal P_face_b = P_b + sycl::dot(grad_P_b, shift_b) + dtP_cell_b * dt_interp;
      |                                                  ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:291:23: warning: invalid case style for variable 'dtP_cell_a' [readability-identifier-naming]
  291 |                 Tscal dtP_cell_a = acc_dt_P_cell[id_a];
      |                       ^~~~~~~~~~
      |                       dt_p_cell_a
  292 |                 Tscal dtP_cell_b = acc_dt_P_cell[id_b];
  293 | 
  294 |                 Tscal P_face_a = P_a + sycl::dot(grad_P_a, shift_a) + dtP_cell_a * dt_interp;
      |                                                                       ~~~~~~~~~~
      |                                                                       dt_p_cell_a
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:291:23: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:294:71: note: FIX-IT applied suggested code changes
  294 |                 Tscal P_face_a = P_a + sycl::dot(grad_P_a, shift_a) + dtP_cell_a * dt_interp;
      |                                                                       ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:292:23: warning: invalid case style for variable 'dtP_cell_b' [readability-identifier-naming]
  292 |                 Tscal dtP_cell_b = acc_dt_P_cell[id_b];
      |                       ^~~~~~~~~~
      |                       dt_p_cell_b
  293 | 
  294 |                 Tscal P_face_a = P_a + sycl::dot(grad_P_a, shift_a) + dtP_cell_a * dt_interp;
  295 |                 Tscal P_face_b = P_b + sycl::dot(grad_P_b, shift_b) + dtP_cell_b * dt_interp;
      |                                                                       ~~~~~~~~~~
      |                                                                       dt_p_cell_b
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:292:23: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:295:71: note: FIX-IT applied suggested code changes
  295 |                 Tscal P_face_b = P_b + sycl::dot(grad_P_b, shift_b) + dtP_cell_b * dt_interp;
      |                                                                       ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:294:23: warning: invalid case style for variable 'P_face_a' [readability-identifier-naming]
  294 |                 Tscal P_face_a = P_a + sycl::dot(grad_P_a, shift_a) + dtP_cell_a * dt_interp;
      |                       ^~~~~~~~
      |                       p_face_a
  295 |                 Tscal P_face_b = P_b + sycl::dot(grad_P_b, shift_b) + dtP_cell_b * dt_interp;
  296 | 
  297 |                 SHAM_ASSERT(P_face_a >= 0.0);
  298 |                 SHAM_ASSERT(P_face_b >= 0.0);
  299 | 
  300 |                 return {P_face_a, P_face_b};
      |                         ~~~~~~~~
      |                         p_face_a
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:294:23: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:300:25: note: FIX-IT applied suggested code changes
  300 |                 return {P_face_a, P_face_b};
      |                         ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:295:23: warning: invalid case style for variable 'P_face_b' [readability-identifier-naming]
  295 |                 Tscal P_face_b = P_b + sycl::dot(grad_P_b, shift_b) + dtP_cell_b * dt_interp;
      |                       ^~~~~~~~
      |                       p_face_b
  296 | 
  297 |                 SHAM_ASSERT(P_face_a >= 0.0);
  298 |                 SHAM_ASSERT(P_face_b >= 0.0);
  299 | 
  300 |                 return {P_face_a, P_face_b};
      |                                   ~~~~~~~~
      |                                   p_face_b
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:295:23: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:300:35: note: FIX-IT applied suggested code changes
  300 |                 return {P_face_a, P_face_b};
      |                                   ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:314:54: warning: the parameter 'e' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
  314 |         inline void complete_event_state(sycl::event e) {
      |                                                      ^
      |                                          const      &
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:314:42: note: FIX-IT applied suggested code changes
  314 |         inline void complete_event_state(sycl::event e) {
      |                                          ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:314:53: note: FIX-IT applied suggested code changes
  314 |         inline void complete_event_state(sycl::event e) {
      |                                                     ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:337:15: warning: invalid case style for class 'acc' [readability-identifier-naming]
  337 |         class acc {
      |               ^~~
      |               Acc
  338 |             public:
  339 |             GetShift<Tvec, TgridVec, AMRBlock> shift_get;
  340 |             u32 nvar;
  341 | 
  342 |             const Tscal *acc_rho_dust_cell;
  343 |             const Tvec *acc_grad_rho_dust_cell;
  344 | 
  345 |             // For time interpolation
  346 |             const Tscal *acc_dt_rho_dust_cell;
  347 | 
  348 |             Tscal dt_interp;
  349 | 
  350 |             acc(u32 nvar,
      |             ~~~
      |             Acc
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:337:15: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:350:13: note: FIX-IT applied suggested code changes
  350 |             acc(u32 nvar,
      |             ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:383:16: note: FIX-IT applied suggested code changes
  383 |         inline acc get_read_access(sham::EventList &deps) {
      |                ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:384:20: note: FIX-IT applied suggested code changes
  384 |             return acc(
      |                    ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:395:54: warning: the parameter 'e' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
  395 |         inline void complete_event_state(sycl::event e) {
      |                                                      ^
      |                                          const      &
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:395:42: note: FIX-IT applied suggested code changes
  395 |         inline void complete_event_state(sycl::event e) {
      |                                          ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:395:53: note: FIX-IT applied suggested code changes
  395 |         inline void complete_event_state(sycl::event e) {
      |                                                     ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:420:15: warning: invalid case style for class 'acc' [readability-identifier-naming]
  420 |         class acc {
      |               ^~~
      |               Acc
  421 |             public:
  422 |             GetShift<Tvec, TgridVec, AMRBlock> shift_get;
  423 |             u32 nvar;
  424 | 
  425 |             const Tvec *acc_vel_dust_cell;
  426 |             const Tvec *acc_dx_v_dust_cell;
  427 |             const Tvec *acc_dy_v_dust_cell;
  428 |             const Tvec *acc_dz_v_dust_cell;
  429 | 
  430 |             // For time interpolation
  431 |             const Tvec *acc_dt_vel_dust_cell;
  432 | 
  433 |             Tscal dt_interp;
  434 | 
  435 |             acc(u32 nvar,
      |             ~~~
      |             Acc
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:420:15: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:435:13: note: FIX-IT applied suggested code changes
  435 |             acc(u32 nvar,
      |             ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:483:16: note: FIX-IT applied suggested code changes
  483 |         inline acc get_read_access(sham::EventList &deps) {
      |                ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:484:20: note: FIX-IT applied suggested code changes
  484 |             return acc(
      |                    ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:497:54: warning: the parameter 'e' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
  497 |         inline void complete_event_state(sycl::event e) {
      |                                                      ^
      |                                          const      &
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:497:42: note: FIX-IT applied suggested code changes
  497 |         inline void complete_event_state(sycl::event e) {
      |                                          ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:497:53: note: FIX-IT applied suggested code changes
  497 |         inline void complete_event_state(sycl::event e) {
      |                                                     ^
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:847:10: warning: invalid case style for variable 'spans_grad_P' [readability-identifier-naming]
  847 |     auto spans_grad_P                = edges.spans_grad_P.get_spans();
      |          ^~~~~~~~~~~~
      |          spans_grad_p
  848 |     auto spans_dt_press              = edges.spans_dt_press.get_spans();
  849 | 
  850 |     using Interp = PressInterpolate<Tvec, TgridVec, AMRBlock>;
  851 |     auto interpolators
  852 |         = spans_block_cell_sizes.template map<Interp>([&](u64 id, auto &csize) -> Interp {
  853 |               return {
  854 |                   spans_cell0block_aabb_lower.get(id),
  855 |                   spans_block_cell_sizes.get(id),
  856 |                   spans_press.get(id),
  857 |                   spans_grad_P.get(id),
      |                   ~~~~~~~~~~~~
      |                   spans_grad_p
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:847:10: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/ramses/src/modules/InterpolateToFace.cpp:857:19: note: FIX-IT applied suggested code changes
  857 |                   spans_grad_P.get(id),
      |                   ^

50618 warnings generated.
clang-tidy applied 62 of 62 suggested fixes.
Suppressed 50595 warnings (50585 in non-user code, 10 due to line filter).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

55586 warnings generated.
Suppressed 55587 warnings (55580 in non-user code, 6 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

Suggested changes

Detailed changes :
diff --git a/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp b/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp
index 6b95ea29..81895f0a 100644
--- a/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp
+++ b/src/shammodels/ramses/src/modules/EulerTimeDerivativeGas.cpp
@@ -38,7 +38,7 @@ namespace {
             const shambase::DistributedData<shamrock::PatchDataFieldSpanPointer<Tvec>> &spans_dy_v,
             const shambase::DistributedData<shamrock::PatchDataFieldSpanPointer<Tvec>> &spans_dz_v,
             const shambase::DistributedData<shamrock::PatchDataFieldSpanPointer<Tvec>>
-                &spans_grad_P,
+                &spans_grad_p,
 
             shambase::DistributedData<shamrock::PatchDataFieldSpanPointer<Tscal>> &spans_dt_rho,
             shambase::DistributedData<shamrock::PatchDataFieldSpanPointer<Tvec>> &spans_dt_vel,
@@ -63,7 +63,7 @@ namespace {
                     spans_dx_v,
                     spans_dy_v,
                     spans_dz_v,
-                    spans_grad_P},
+                    spans_grad_p},
                 sham::DDMultiRef{spans_dt_rho, spans_dt_vel, spans_dt_press},
                 cell_counts,
                 [gamma](
@@ -75,28 +75,28 @@ namespace {
                     const Tvec *__restrict dx_v,
                     const Tvec *__restrict dy_v,
                     const Tvec *__restrict dz_v,
-                    const Tvec *__restrict grad_P,
+                    const Tvec *__restrict grad_p,
                     Tscal *__restrict dt_rho,
                     Tvec *__restrict dt_vel,
                     Tscal *__restrict dt_press) {
                     Tscal rho_i     = rho[i];
                     Tvec v_i        = vel[i];
-                    Tscal P_i       = press[i];
+                    Tscal p_i       = press[i];
                     Tvec grad_rho_i = grad_rho[i];
                     Tvec dx_v_i     = dx_v[i];
                     Tvec dy_v_i     = dy_v[i];
                     Tvec dz_v_i     = dz_v[i];
-                    Tvec grad_P_i   = grad_P[i];
+                    Tvec grad_p_i   = grad_p[i];
 
                     dt_rho[i] = -(
                         sham::dot(v_i, grad_rho_i) + rho_i * (dx_v_i[0] + dy_v_i[1] + dz_v_i[2]));
 
                     dt_vel[i]
-                        = -(v_i[0] * dx_v_i + v_i[1] * dy_v_i + v_i[2] * dz_v_i + grad_P_i / rho_i);
+                        = -(v_i[0] * dx_v_i + v_i[1] * dy_v_i + v_i[2] * dz_v_i + grad_p_i / rho_i);
 
                     dt_press[i]
-                        = -(gamma * P_i * (dx_v_i[0] + dy_v_i[1] + dz_v_i[2])
-                            + sham::dot(v_i, grad_P_i));
+                        = -(gamma * p_i * (dx_v_i[0] + dy_v_i[1] + dz_v_i[2])
+                            + sham::dot(v_i, grad_p_i));
                 });
         }
     };
@@ -150,7 +150,7 @@ namespace shammodels::basegodunov::modules {
         auto dx_v        = get_ro_edge_base(5).get_tex_symbol();
         auto dy_v        = get_ro_edge_base(6).get_tex_symbol();
         auto dz_v        = get_ro_edge_base(7).get_tex_symbol();
-        auto grad_P      = get_ro_edge_base(8).get_tex_symbol();
+        auto grad_p      = get_ro_edge_base(8).get_tex_symbol();
         auto dt_rho      = get_rw_edge_base(0).get_tex_symbol();
         auto dt_vel      = get_rw_edge_base(1).get_tex_symbol();
         auto dt_press    = get_rw_edge_base(2).get_tex_symbol();
@@ -182,7 +182,7 @@ namespace shammodels::basegodunov::modules {
         shambase::replace_all(tex, "{dx_v}", dx_v);
         shambase::replace_all(tex, "{dy_v}", dy_v);
         shambase::replace_all(tex, "{dz_v}", dz_v);
-        shambase::replace_all(tex, "{grad_P}", grad_P);
+        shambase::replace_all(tex, "{grad_P}", grad_p);
         shambase::replace_all(tex, "{block_count}", block_count);
         shambase::replace_all(tex, "{gamma}", sham::format("{}", gamma));
         shambase::replace_all(tex, "{block_size}", sham::format("{}", block_size));
diff --git a/src/shammodels/ramses/src/modules/InterpolateToFace.cpp b/src/shammodels/ramses/src/modules/InterpolateToFace.cpp
index d5d1b297..2f9ca051 100644
--- a/src/shammodels/ramses/src/modules/InterpolateToFace.cpp
+++ b/src/shammodels/ramses/src/modules/InterpolateToFace.cpp
@@ -84,7 +84,7 @@ namespace {
         Tscal dt_interp;
         shamrock::PatchDataFieldSpanPointer<Tscal> dt_rho_cell;
 
-        class acc {
+        class Acc {
             public:
             GetShift<Tvec, TgridVec, AMRBlock> shift_get;
 
@@ -96,7 +96,7 @@ namespace {
 
             Tscal dt_interp;
 
-            acc(const Tvec *aabb_block_lower,
+            Acc(const Tvec *aabb_block_lower,
                 const Tscal *aabb_cell_size,
                 const Tscal *rho_cell,
                 const Tvec *grad_rho_cell,
@@ -128,8 +128,8 @@ namespace {
             }
         };
 
-        inline acc get_read_access(sham::EventList &deps) {
-            return acc(
+        inline Acc get_read_access(sham::EventList &deps) {
+            return Acc(
                 aabb_block_lower.get_read_access(deps),
                 aabb_cell_size.get_read_access(deps),
                 rho_cell.get_read_access(deps),
@@ -139,7 +139,7 @@ namespace {
                 dt_rho_cell.get_read_access(deps));
         }
 
-        inline void complete_event_state(sycl::event e) {
+        inline void complete_event_state(const sycl::event& e) {
             aabb_block_lower.complete_event_state(e);
             aabb_cell_size.complete_event_state(e);
             rho_cell.complete_event_state(e);
@@ -164,7 +164,7 @@ namespace {
         Tscal dt_interp;
         shamrock::PatchDataFieldSpanPointer<Tvec> dt_vel_cell;
 
-        class acc {
+        class Acc {
             public:
             GetShift<Tvec, TgridVec, AMRBlock> shift_get;
 
@@ -178,7 +178,7 @@ namespace {
 
             Tscal dt_interp;
 
-            acc(const Tvec *aabb_block_lower,
+            Acc(const Tvec *aabb_block_lower,
                 const Tscal *aabb_cell_size,
                 const Tvec *vel_cell,
                 const Tvec *dx_v_cell,
@@ -220,8 +220,8 @@ namespace {
             }
         };
 
-        inline acc get_read_access(sham::EventList &deps) {
-            return acc(
+        inline Acc get_read_access(sham::EventList &deps) {
+            return Acc(
                 aabb_block_lower.get_read_access(deps),
                 aabb_cell_size.get_read_access(deps),
                 vel_cell.get_read_access(deps),
@@ -233,7 +233,7 @@ namespace {
                 dt_vel_cell.get_read_access(deps));
         }
 
-        inline void complete_event_state(sycl::event e) {
+        inline void complete_event_state(const sycl::event& e) {
             aabb_block_lower.complete_event_state(e);
             aabb_cell_size.complete_event_state(e);
             vel_cell.complete_event_state(e);
@@ -252,71 +252,71 @@ namespace {
         shamrock::PatchDataFieldSpanPointer<Tvec> aabb_block_lower;
         shamrock::PatchDataFieldSpanPointer<Tscal> aabb_cell_size;
         shamrock::PatchDataFieldSpanPointer<Tscal> P_cell;
-        shamrock::PatchDataFieldSpanPointer<Tvec> grad_P_cell;
+        shamrock::PatchDataFieldSpanPointer<Tvec> grad_p_cell;
         // For time interpolation
         Tscal dt_interp;
-        shamrock::PatchDataFieldSpanPointer<Tscal> dt_P_cell;
+        shamrock::PatchDataFieldSpanPointer<Tscal> dt_p_cell;
 
-        class acc {
+        class Acc {
             public:
             GetShift<Tvec, TgridVec, AMRBlock> shift_get;
 
             const Tscal *acc_P_cell;
-            const Tvec *acc_grad_P_cell;
+            const Tvec *acc_grad_p_cell;
 
             // For time interpolation
-            const Tscal *acc_dt_P_cell;
+            const Tscal *acc_dt_p_cell;
 
             Tscal dt_interp;
 
-            acc(const Tvec *aabb_block_lower,
+            Acc(const Tvec *aabb_block_lower,
                 const Tscal *aabb_cell_size,
                 const Tscal *P_cell,
-                const Tvec *grad_P_cell,
+                const Tvec *grad_p_cell,
                 // For time interpolation
                 Tscal dt_interp,
-                const Tscal *dt_P_cell)
+                const Tscal *dt_p_cell)
                 : shift_get(aabb_block_lower, aabb_cell_size), acc_P_cell{P_cell},
-                  acc_grad_P_cell{grad_P_cell}, acc_dt_P_cell{dt_P_cell}, dt_interp(dt_interp) {}
+                  acc_grad_p_cell{grad_p_cell}, acc_dt_p_cell{dt_p_cell}, dt_interp(dt_interp) {}
 
             std::array<Tscal, 2> get_link_field_val(u32 id_a, u32 id_b) const {
 
                 auto [shift_a, shift_b] = shift_get.get_shifts(id_a, id_b);
 
                 Tscal P_a     = acc_P_cell[id_a];
-                Tvec grad_P_a = acc_grad_P_cell[id_a];
-                Tscal P_b     = acc_P_cell[id_b];
-                Tvec grad_P_b = acc_grad_P_cell[id_b];
+                Tvec grad_P_a = acc_grad_p_cell[id_a];
+                Tscal p_b     = acc_P_cell[id_b];
+                Tvec grad_p_b = acc_grad_p_cell[id_b];
 
-                Tscal dtP_cell_a = acc_dt_P_cell[id_a];
-                Tscal dtP_cell_b = acc_dt_P_cell[id_b];
+                Tscal dt_p_cell_a = acc_dt_p_cell[id_a];
+                Tscal dt_p_cell_b = acc_dt_p_cell[id_b];
 
-                Tscal P_face_a = P_a + sycl::dot(grad_P_a, shift_a) + dtP_cell_a * dt_interp;
-                Tscal P_face_b = P_b + sycl::dot(grad_P_b, shift_b) + dtP_cell_b * dt_interp;
+                Tscal p_face_a = P_a + sycl::dot(grad_P_a, shift_a) + dt_p_cell_a * dt_interp;
+                Tscal p_face_b = p_b + sycl::dot(grad_p_b, shift_b) + dt_p_cell_b * dt_interp;
 
                 SHAM_ASSERT(P_face_a >= 0.0);
                 SHAM_ASSERT(P_face_b >= 0.0);
 
-                return {P_face_a, P_face_b};
+                return {p_face_a, p_face_b};
             }
         };
 
-        inline acc get_read_access(sham::EventList &deps) {
-            return acc(
+        inline Acc get_read_access(sham::EventList &deps) {
+            return Acc(
                 aabb_block_lower.get_read_access(deps),
                 aabb_cell_size.get_read_access(deps),
                 P_cell.get_read_access(deps),
-                grad_P_cell.get_read_access(deps),
+                grad_p_cell.get_read_access(deps),
                 dt_interp,
-                dt_P_cell.get_read_access(deps));
+                dt_p_cell.get_read_access(deps));
         }
 
-        inline void complete_event_state(sycl::event e) {
+        inline void complete_event_state(const sycl::event& e) {
             aabb_block_lower.complete_event_state(e);
             aabb_cell_size.complete_event_state(e);
             P_cell.complete_event_state(e);
-            grad_P_cell.complete_event_state(e);
-            dt_P_cell.complete_event_state(e);
+            grad_p_cell.complete_event_state(e);
+            dt_p_cell.complete_event_state(e);
         }
     };
 
@@ -334,7 +334,7 @@ namespace {
         Tscal dt_interp;
         shamrock::PatchDataFieldSpanPointer<Tscal> dt_rho_dust_cell;
 
-        class acc {
+        class Acc {
             public:
             GetShift<Tvec, TgridVec, AMRBlock> shift_get;
             u32 nvar;
@@ -347,7 +347,7 @@ namespace {
 
             Tscal dt_interp;
 
-            acc(u32 nvar,
+            Acc(u32 nvar,
                 const Tvec *aabb_block_lower,
                 const Tscal *aabb_cell_size,
                 const Tscal *rho_dust_cell,
@@ -380,8 +380,8 @@ namespace {
             }
         };
 
-        inline acc get_read_access(sham::EventList &deps) {
-            return acc(
+        inline Acc get_read_access(sham::EventList &deps) {
+            return Acc(
                 nvar,
                 aabb_block_lower.get_read_access(deps),
                 aabb_cell_size.get_read_access(deps),
@@ -392,7 +392,7 @@ namespace {
                 dt_rho_dust_cell.get_read_access(deps));
         }
 
-        inline void complete_event_state(sycl::event e) {
+        inline void complete_event_state(const sycl::event& e) {
             aabb_block_lower.complete_event_state(e);
             aabb_cell_size.complete_event_state(e);
             rho_dust_cell.complete_event_state(e);
@@ -417,7 +417,7 @@ namespace {
         Tscal dt_interp;
         shamrock::PatchDataFieldSpanPointer<Tvec> dt_vel_dust_cell;
 
-        class acc {
+        class Acc {
             public:
             GetShift<Tvec, TgridVec, AMRBlock> shift_get;
             u32 nvar;
@@ -432,7 +432,7 @@ namespace {
 
             Tscal dt_interp;
 
-            acc(u32 nvar,
+            Acc(u32 nvar,
                 const Tvec *aabb_block_lower,
                 const Tscal *aabb_cell_size,
                 const Tvec *vel_dust_cell,
@@ -480,8 +480,8 @@ namespace {
             }
         };
 
-        inline acc get_read_access(sham::EventList &deps) {
-            return acc(
+        inline Acc get_read_access(sham::EventList &deps) {
+            return Acc(
                 nvar,
                 aabb_block_lower.get_read_access(deps),
                 aabb_cell_size.get_read_access(deps),
@@ -494,7 +494,7 @@ namespace {
                 dt_vel_dust_cell.get_read_access(deps));
         }
 
-        inline void complete_event_state(sycl::event e) {
+        inline void complete_event_state(const sycl::event& e) {
             aabb_block_lower.complete_event_state(e);
             aabb_cell_size.complete_event_state(e);
             vel_dust_cell.complete_event_state(e);
@@ -844,7 +844,7 @@ void shammodels::basegodunov::modules::InterpolateToFacePress<Tvec, TgridVec>::
     auto spans_block_cell_sizes      = edges.spans_block_cell_sizes.get_spans();
     auto spans_cell0block_aabb_lower = edges.spans_cell0block_aabb_lower.get_spans();
     auto spans_press                 = edges.spans_press.get_spans();
-    auto spans_grad_P                = edges.spans_grad_P.get_spans();
+    auto spans_grad_p                = edges.spans_grad_P.get_spans();
     auto spans_dt_press              = edges.spans_dt_press.get_spans();
 
     using Interp = PressInterpolate<Tvec, TgridVec, AMRBlock>;
@@ -854,7 +854,7 @@ void shammodels::basegodunov::modules::InterpolateToFacePress<Tvec, TgridVec>::
                   spans_cell0block_aabb_lower.get(id),
                   spans_block_cell_sizes.get(id),
                   spans_press.get(id),
-                  spans_grad_P.get(id),
+                  spans_grad_p.get(id),
                   dt_interp,
                   spans_dt_press.get(id)};
           });
# Doxygen diff with `main` Removed warnings : 208 New warnings : 124 Warnings count : 8390 → 8306 (-1.0%)
Detailed changes :
+ src/shammodels/ramses/include/shammodels/ramses/modules/EulerTimeDerivativeDust.hpp:24: warning: Member NODE_EDGES(X_RO, X_RW) (macro definition) of file EulerTimeDerivativeDust.hpp is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/EulerTimeDerivativeDust.hpp:55: warning: Member NodeEulerTimeDerivativeDust(u32 block_size, u32 ndust) (function) of class shammodels::basegodunov::modules::NodeEulerTimeDerivativeDust is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/EulerTimeDerivativeGas.hpp:24: warning: Member NODE_EDGES(X_RO, X_RW) (macro definition) of file EulerTimeDerivativeGas.hpp is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/EulerTimeDerivativeGas.hpp:59: warning: Member NodeEulerTimeDerivativeGas(u32 block_size, Tscal gamma) (function) of class shammodels::basegodunov::modules::NodeEulerTimeDerivativeGas is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:108: warning: Member get_edges() (function) of class shammodels::basegodunov::modules::InterpolateToFaceRho is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:109: warning: Member NODE_EDGES_VEL_DUST(X_RO, X_RW) (macro definition) of file InterpolateToFace.hpp is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:132: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceRho is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:137: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceVel is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:143: warning: Member InterpolateToFaceRho(u32 block_size) (function) of class shammodels::basegodunov::modules::InterpolateToFaceRho is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:145: warning: Member InterpolateToFaceVel(u32 block_size) (function) of class shammodels::basegodunov::modules::InterpolateToFaceVel is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:147: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:148: warning: Member dt_interp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:150: warning: Member cell_neigh_graph (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:152: warning: Member spans_block_cell_sizes (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:153: warning: Member spans_cell0block_aabb_lower (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:154: warning: Member spans_rhos (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:155: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceVel is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:155: warning: Member spans_grad_P (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:156: warning: Member spans_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:157: warning: Member spans_dx_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:158: warning: Member spans_dy_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:159: warning: Member spans_dz_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:161: warning: Member vel_face_xp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:162: warning: Member vel_face_xm (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:163: warning: Member vel_face_yp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:164: warning: Member vel_face_ym (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:165: warning: Member vel_face_zp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:166: warning: Member InterpolateToFaceVel(u32 block_size) (function) of class shammodels::basegodunov::modules::InterpolateToFaceVel is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:166: warning: Member vel_face_zm (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVel::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:169: warning: Member set_edges(std::shared_ptr< shamrock::solvergraph::ScalarEdge< Tscal > > dt_interp, std::shared_ptr< solvergraph::OrientedAMRGraphEdge< Tvec, TgridVec > > cell_neigh_graph, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > spans_block_cell_sizes, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_cell0block_aabb_lower, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > spans_rhos, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_grad_P, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_vel, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dx_vel, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dy_vel, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dz_vel, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_face_xp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_face_xm, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_face_yp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_face_ym, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_face_zp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_face_zm) (function) of class shammodels::basegodunov::modules::InterpolateToFaceVel is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:178: warning: Compound shammodels::basegodunov::modules::InterpolateToFacePress is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:189: warning: Member InterpolateToFacePress(u32 block_size) (function) of class shammodels::basegodunov::modules::InterpolateToFacePress is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:203: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceRhoDust is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:210: warning: Member get_edges() (function) of class shammodels::basegodunov::modules::InterpolateToFaceVel is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:215: warning: Member InterpolateToFaceRhoDust(u32 block_size, u32 ndust) (function) of class shammodels::basegodunov::modules::InterpolateToFaceRhoDust is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:230: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceVelDust is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:239: warning: Compound shammodels::basegodunov::modules::InterpolateToFacePress is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:242: warning: Member InterpolateToFaceVelDust(u32 block_size, u32 ndust) (function) of class shammodels::basegodunov::modules::InterpolateToFaceVelDust is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:248: warning: Member InterpolateToFacePress(u32 block_size, Tscal gamma) (function) of class shammodels::basegodunov::modules::InterpolateToFacePress is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:251: warning: Compound shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:252: warning: Member dt_interp (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:254: warning: Member cell_neigh_graph (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:256: warning: Member spans_block_cell_sizes (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:257: warning: Member spans_cell0block_aabb_lower (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:258: warning: Member spans_press (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:259: warning: Member spans_grad_P (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:260: warning: Member spans_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:261: warning: Member spans_dx_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:262: warning: Member spans_dy_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:263: warning: Member spans_dz_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:265: warning: Member press_face_xp (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:266: warning: Member press_face_xm (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:267: warning: Member press_face_yp (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:268: warning: Member press_face_ym (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:269: warning: Member press_face_zp (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:270: warning: Member press_face_zm (variable) of struct shammodels::basegodunov::modules::InterpolateToFacePress::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:273: warning: Member set_edges(std::shared_ptr< shamrock::solvergraph::ScalarEdge< Tscal > > dt_interp, std::shared_ptr< solvergraph::OrientedAMRGraphEdge< Tvec, TgridVec > > cell_neigh_graph, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > spans_block_cell_sizes, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_cell0block_aabb_lower, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > spans_press, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_grad_P, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_vel, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dx_vel, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dy_vel, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dz_vel, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &press_face_xp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &press_face_xm, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &press_face_yp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &press_face_ym, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &press_face_zp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &press_face_zm) (function) of class shammodels::basegodunov::modules::InterpolateToFacePress is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:319: warning: Member get_edges() (function) of class shammodels::basegodunov::modules::InterpolateToFacePress is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:31: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceRho is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:350: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceRhoDust is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:359: warning: Member InterpolateToFaceRhoDust(u32 block_size, u32 ndust) (function) of class shammodels::basegodunov::modules::InterpolateToFaceRhoDust is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:35: warning: Member NODE_EDGES_RHO(X_RO, X_RW) (macro definition) of file InterpolateToFace.hpp is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:362: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:363: warning: Member dt_interp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:365: warning: Member cell_neigh_graph (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:367: warning: Member spans_block_cell_sizes (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:368: warning: Member spans_cell0block_aabb_lower (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:369: warning: Member spans_rhos_dust (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:370: warning: Member spans_grad_rho_dust (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:371: warning: Member spans_vel_dust (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:372: warning: Member spans_dx_vel_dust (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:373: warning: Member spans_dy_vel_dust (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:374: warning: Member spans_dz_vel_dust (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:376: warning: Member rho_dust_face_xp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:377: warning: Member rho_dust_face_xm (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:378: warning: Member rho_dust_face_yp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:379: warning: Member rho_dust_face_ym (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:380: warning: Member rho_dust_face_zp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:381: warning: Member rho_dust_face_zm (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRhoDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:384: warning: Member set_edges(std::shared_ptr< shamrock::solvergraph::ScalarEdge< Tscal > > dt_interp, std::shared_ptr< solvergraph::OrientedAMRGraphEdge< Tvec, TgridVec > > cell_neigh_graph, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > spans_block_cell_sizes, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_cell0block_aabb_lower, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > spans_rhos_dust, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_grad_rho_dust, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_vel_dust, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dx_vel_dust, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dy_vel_dust, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dz_vel_dust, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_dust_face_xp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_dust_face_xm, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_dust_face_yp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_dust_face_ym, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_dust_face_zp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_dust_face_zm) (function) of class shammodels::basegodunov::modules::InterpolateToFaceRhoDust is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:39: warning: Member InterpolateToFaceRho(u32 block_size) (function) of class shammodels::basegodunov::modules::InterpolateToFaceRho is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:41: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:429: warning: Member get_edges() (function) of class shammodels::basegodunov::modules::InterpolateToFaceRhoDust is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:42: warning: Member dt_interp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:44: warning: Member cell_neigh_graph (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:458: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceVelDust is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:467: warning: Member InterpolateToFaceVelDust(u32 block_size, u32 ndust) (function) of class shammodels::basegodunov::modules::InterpolateToFaceVelDust is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:46: warning: Member spans_block_cell_sizes (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:470: warning: Compound shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:471: warning: Member dt_interp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:473: warning: Member cell_neigh_graph (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:475: warning: Member spans_block_cell_sizes (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:476: warning: Member spans_cell0block_aabb_lower (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:477: warning: Member spans_rhos_dust (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:478: warning: Member spans_vel_dust (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:479: warning: Member spans_dx_vel_dust (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:47: warning: Member spans_cell0block_aabb_lower (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:480: warning: Member spans_dy_vel_dust (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:481: warning: Member spans_dz_vel_dust (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:483: warning: Member vel_dust_face_xp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:484: warning: Member vel_dust_face_xm (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:485: warning: Member vel_dust_face_yp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:486: warning: Member vel_dust_face_ym (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:487: warning: Member vel_dust_face_zp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:488: warning: Member vel_dust_face_zm (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceVelDust::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:48: warning: Member spans_rhos (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:491: warning: Member set_edges(std::shared_ptr< shamrock::solvergraph::ScalarEdge< Tscal > > dt_interp, std::shared_ptr< solvergraph::OrientedAMRGraphEdge< Tvec, TgridVec > > cell_neigh_graph, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > spans_block_cell_sizes, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_cell0block_aabb_lower, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > spans_rhos_dust, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_vel_dust, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dx_vel_dust, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dy_vel_dust, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dz_vel_dust, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_dust_face_xp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_dust_face_xm, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_dust_face_yp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_dust_face_ym, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_dust_face_zp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tvec, 2 > > > &vel_dust_face_zm) (function) of class shammodels::basegodunov::modules::InterpolateToFaceVelDust is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:49: warning: Member spans_grad_rho (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:50: warning: Member spans_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:51: warning: Member spans_dx_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:52: warning: Member spans_dy_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:535: warning: Member get_edges() (function) of class shammodels::basegodunov::modules::InterpolateToFaceVelDust is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:53: warning: Member NODE_EDGES_VEL(X_RO, X_RW) (macro definition) of file InterpolateToFace.hpp is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:53: warning: Member spans_dz_vel (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:55: warning: Member rho_face_xp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:56: warning: Member rho_face_xm (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:57: warning: Member rho_face_yp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:58: warning: Member rho_face_ym (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:59: warning: Member rho_face_zp (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:60: warning: Member rho_face_zm (variable) of struct shammodels::basegodunov::modules::InterpolateToFaceRho::Edges is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:63: warning: Member set_edges(std::shared_ptr< shamrock::solvergraph::ScalarEdge< Tscal > > dt_interp, std::shared_ptr< solvergraph::OrientedAMRGraphEdge< Tvec, TgridVec > > cell_neigh_graph, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > spans_block_cell_sizes, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_cell0block_aabb_lower, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > spans_rhos, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_grad_rho, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_vel, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dx_vel, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dy_vel, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > spans_dz_vel, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_face_xp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_face_xm, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_face_yp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_face_ym, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_face_zp, std::shared_ptr< solvergraph::NeighGraphLinkFieldEdge< std::array< Tscal, 2 > > > &rho_face_zm) (function) of class shammodels::basegodunov::modules::InterpolateToFaceRho is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:73: warning: Member NODE_EDGES_PRESS(X_RO, X_RW) (macro definition) of file InterpolateToFace.hpp is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/InterpolateToFace.hpp:91: warning: Member NODE_EDGES_RHO_DUST(X_RO, X_RW) (macro definition) of file InterpolateToFace.hpp is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:121: warning: Member rho_mean (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:122: warning: Member simulation_volume (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:123: warning: Member cell_mass (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:125: warning: Member merge_patch_bounds (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:127: warning: Member trees (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:130: warning: Member block_graph_edge (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:132: warning: Member rho_mean (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:133: warning: Member cell_graph_edge (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:133: warning: Member simulation_volume (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:134: warning: Member cell_mass (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:135: warning: Member solver_sequence (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:136: warning: Member merge_patch_bounds (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:137: warning: Member node_cons_to_prim (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:138: warning: Member build_trees (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:138: warning: Member trees (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:140: warning: Member serial_patch_tree (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:141: warning: Member block_graph_edge (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:142: warning: Member ghost_zone_infos (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:144: warning: Member cell_graph_edge (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:144: warning: Member ghost_layout (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:146: warning: Member solver_sequence (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:146: warning: Member source_patches (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:148: warning: Member merged_patchdata_ghost (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:148: warning: Member node_cons_to_prim (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:149: warning: Member build_trees (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:150: warning: Member exchange_gz_edge (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:151: warning: Member serial_patch_tree (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:153: warning: Member ghost_layers_candidates_edge (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:153: warning: Member ghost_zone_infos (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:155: warning: Member ghost_layout (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:155: warning: Member sim_box_edge (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:157: warning: Member idx_in_ghost (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:157: warning: Member source_patches (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:159: warning: Member merged_patchdata_ghost (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:159: warning: Member rho_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:160: warning: Member rho_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:161: warning: Member exchange_gz_edge (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:161: warning: Member rho_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:162: warning: Member rho_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:163: warning: Member rho_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:164: warning: Member ghost_layers_candidates_edge (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:164: warning: Member rho_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:166: warning: Member sim_box_edge (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:166: warning: Member vel_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:167: warning: Member vel_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:168: warning: Member idx_in_ghost (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:168: warning: Member vel_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:169: warning: Member vel_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:170: warning: Member rho_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:170: warning: Member vel_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:171: warning: Member rho_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:171: warning: Member vel_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:172: warning: Member rho_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:173: warning: Member press_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:173: warning: Member rho_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:174: warning: Member press_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:174: warning: Member rho_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:175: warning: Member press_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:175: warning: Member rho_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:176: warning: Member press_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:177: warning: Member press_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:177: warning: Member vel_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:178: warning: Member press_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:178: warning: Member vel_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:179: warning: Member vel_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:180: warning: Member flux_rho_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:180: warning: Member vel_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:181: warning: Member flux_rho_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:181: warning: Member vel_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:182: warning: Member flux_rho_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:182: warning: Member vel_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:183: warning: Member flux_rho_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:184: warning: Member flux_rho_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:184: warning: Member press_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:185: warning: Member flux_rho_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:185: warning: Member press_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:186: warning: Member press_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:187: warning: Member flux_rhov_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:187: warning: Member press_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:188: warning: Member flux_rhov_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:188: warning: Member press_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:189: warning: Member flux_rhov_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:189: warning: Member press_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:190: warning: Member flux_rhov_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:191: warning: Member flux_rho_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:191: warning: Member flux_rhov_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:192: warning: Member flux_rho_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:192: warning: Member flux_rhov_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:193: warning: Member flux_rho_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:194: warning: Member flux_rho_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:194: warning: Member flux_rhoe_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:195: warning: Member flux_rho_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:195: warning: Member flux_rhoe_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:196: warning: Member flux_rho_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:196: warning: Member flux_rhoe_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:197: warning: Member flux_rhoe_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:198: warning: Member flux_rhoe_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:198: warning: Member flux_rhov_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:199: warning: Member flux_rhoe_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:199: warning: Member flux_rhov_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:200: warning: Member flux_rhov_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:201: warning: Member flux_rho_dust_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:201: warning: Member flux_rhov_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:202: warning: Member flux_rho_dust_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:202: warning: Member flux_rhov_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:203: warning: Member flux_rho_dust_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:203: warning: Member flux_rhov_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:204: warning: Member flux_rho_dust_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:205: warning: Member flux_rho_dust_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:205: warning: Member flux_rhoe_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:206: warning: Member flux_rho_dust_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:206: warning: Member flux_rhoe_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:207: warning: Member flux_rhoe_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:208: warning: Member flux_rhoe_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:208: warning: Member flux_rhov_dust_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:209: warning: Member flux_rhoe_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:209: warning: Member flux_rhov_dust_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:210: warning: Member flux_rhoe_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:210: warning: Member flux_rhov_dust_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:211: warning: Member flux_rhov_dust_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:212: warning: Member flux_rho_dust_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:212: warning: Member flux_rhov_dust_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:213: warning: Member flux_rho_dust_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:213: warning: Member flux_rhov_dust_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:214: warning: Member flux_rho_dust_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:215: warning: Member dtrho (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:215: warning: Member flux_rho_dust_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:216: warning: Member dtrhov (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:216: warning: Member flux_rho_dust_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:217: warning: Member dtrhoe (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:217: warning: Member flux_rho_dust_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:219: warning: Member flux_rhov_dust_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:219: warning: Member rho_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:220: warning: Member flux_rhov_dust_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:220: warning: Member rhov_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:221: warning: Member flux_rhov_dust_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:221: warning: Member rhoe_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:222: warning: Member flux_rhov_dust_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:223: warning: Member flux_rhov_dust_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:224: warning: Member flux_rhov_dust_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:224: warning: Member rho_d_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:226: warning: Member dtrho (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:226: warning: Member rhov_d_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:227: warning: Member dtrhov (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:228: warning: Member dtrhoe (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:229: warning: Member rho_dust_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:230: warning: Member rho_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:231: warning: Member rho_dust_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:231: warning: Member rhov_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:232: warning: Member rhoe_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:233: warning: Member rho_dust_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:235: warning: Member rho_d_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:235: warning: Member rho_dust_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:237: warning: Member rho_dust_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:237: warning: Member rhov_d_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:239: warning: Member rho_dust_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:240: warning: Member rho_dust_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:241: warning: Member vel_dust_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:242: warning: Member rho_dust_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:242: warning: Member vel_dust_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:243: warning: Member vel_dust_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:244: warning: Member rho_dust_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:244: warning: Member vel_dust_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:245: warning: Member vel_dust_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:246: warning: Member rho_dust_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:246: warning: Member vel_dust_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:248: warning: Member rho_dust_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:249: warning: Member dtrho_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:250: warning: Member rho_dust_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:251: warning: Member dtrhov_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:252: warning: Member vel_dust_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:253: warning: Compound shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:253: warning: Member vel_dust_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:254: warning: Member interface (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:254: warning: Member vel_dust_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:255: warning: Member neighbors (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:255: warning: Member vel_dust_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:256: warning: Member io (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:256: warning: Member vel_dust_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:257: warning: Member vel_dust_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:260: warning: Member dtrho_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:260: warning: Member timings_details (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:262: warning: Member dtrhov_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:264: warning: Compound shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:265: warning: Member interface (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:266: warning: Member neighbors (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:267: warning: Member io (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:271: warning: Member timings_details (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/src/Solver.cpp:268: warning: Member _impl_get_label() (function) of class PatchDataLayerToVtk is not documented.
+ src/shammodels/ramses/src/Solver.cpp:270: warning: Member _impl_get_label() (function) of class PatchDataLayerToVtk is not documented.
- src/shammodels/ramses/src/Solver.cpp:270: warning: Member _impl_get_tex() (function) of class PatchDataLayerToVtk is not documented.
+ src/shammodels/ramses/src/Solver.cpp:272: warning: Member _impl_get_tex() (function) of class PatchDataLayerToVtk is not documented.
- src/shammodels/ramses/src/Solver.cpp:70: warning: Compound PatchDataLayerToVtk is not documented.
+ src/shammodels/ramses/src/Solver.cpp:72: warning: Compound PatchDataLayerToVtk is not documented.
- src/shammodels/ramses/src/Solver.cpp:77: warning: Member PatchDataLayerToVtk(bool write_id_patch, bool write_world_rank, u32 block_size) (function) of class PatchDataLayerToVtk is not documented.
+ src/shammodels/ramses/src/Solver.cpp:79: warning: Member PatchDataLayerToVtk(bool write_id_patch, bool write_world_rank, u32 block_size) (function) of class PatchDataLayerToVtk is not documented.
- src/shammodels/ramses/src/Solver.cpp:81: warning: Compound PatchDataLayerToVtk::Edges is not documented.
+ src/shammodels/ramses/src/Solver.cpp:83: warning: Compound PatchDataLayerToVtk::Edges is not documented.
- src/shammodels/ramses/src/Solver.cpp:83: warning: Member filename (variable) of struct PatchDataLayerToVtk::Edges is not documented.
- src/shammodels/ramses/src/Solver.cpp:84: warning: Member patch_data_layers (variable) of struct PatchDataLayerToVtk::Edges is not documented.
+ src/shammodels/ramses/src/Solver.cpp:85: warning: Member filename (variable) of struct PatchDataLayerToVtk::Edges is not documented.
+ src/shammodels/ramses/src/Solver.cpp:86: warning: Member patch_data_layers (variable) of struct PatchDataLayerToVtk::Edges is not documented.
- src/shammodels/ramses/src/Solver.cpp:87: warning: Member set_edges(std::shared_ptr< shamrock::solvergraph::IDataEdge< std::string > > filename, std::shared_ptr< shamrock::solvergraph::IPatchDataLayerRefs > patch_data_layers) (function) of class PatchDataLayerToVtk is not documented.
+ src/shammodels/ramses/src/Solver.cpp:89: warning: Member set_edges(std::shared_ptr< shamrock::solvergraph::IDataEdge< std::string > > filename, std::shared_ptr< shamrock::solvergraph::IPatchDataLayerRefs > patch_data_layers) (function) of class PatchDataLayerToVtk is not documented.
- src/shammodels/ramses/src/Solver.cpp:94: warning: Member get_edges() (function) of class PatchDataLayerToVtk is not documented.
+ src/shammodels/ramses/src/Solver.cpp:96: warning: Member get_edges() (function) of class PatchDataLayerToVtk is not documented.

@tdavidcl

Copy link
Copy Markdown
Member Author

@Mergifyio queue

@mergify

mergify Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 3 hours 8 minutes 10 seconds in the queue, including 2 hours 56 minutes 40 seconds running CI.

Required conditions to merge
  • check-success = all

@mergify mergify Bot added the queued label Sep 14, 2026
@mergify
mergify Bot merged commit e44c659 into Shamrock-code:main Sep 14, 2026
38 checks passed
@mergify mergify Bot removed the queued label Sep 14, 2026
@tdavidcl
tdavidcl deleted the claude/beautiful-cannon-qx2gtv branch September 14, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants