merge queue: checking #2376 + #2363 + #2333 + #2375 + #2372 together on main (8c054a1) - #2377
Closed
mergify[bot] wants to merge 11 commits into
Closed
mergify[bot] wants to merge 11 commits into
mergify[bot] wants to merge 11 commits into
Conversation
On the Mergify merge queue, a failure in build_push_docker, make_documentation, or shamrock_linux_acpp_phystests already dooms the merge gate. Cancel the whole run right away instead of waiting on the remaining CI jobs (asan, ubsan, tidy, coverage, pylib) to finish. Assisted-by: Claude
evolve_until() mixed timestep-loop control flow with wall-clock-budget bookkeeping (when to next check walltime, whether the limit was hit). Move that logic into a standalone WalltimeLimiter struct so the loop body reads as plain control flow. NFC. Assisted-by: Claude Code
Register the sink predictor's velocity/position leapfrog update as a "sink predictor" node in the solver graph, gated on the "has_sinks" edge via OperationIf (mirroring "sink ext force"), instead of building the nodes ad hoc inside SinkParticlesUpdate::predictor_step every timestep. The call site now just evaluates the registered node. Assisted-by: Claude Code
Converts ExchangeGhostLayerDebugDotGraph, ExtractCounts, GetFieldRefFromLayer and GetObjCntFromLayer to the EXPAND_NODE_EDGES macro, replacing the hand-written Edges struct/set_edges/get_edges boilerplate with the generated equivalent, matching the pattern used elsewhere in shamrock/solvergraph. Assisted-by: Claude
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Thanks @mergify[bot] for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
This was referenced Sep 17, 2026
Contributor
Workflow reportworkflow report corresponding to commit d8ded28 Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportDoxygen diff with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This combination of pull requests has been checked successfully and will be merged soon. 🎉
#2376 + #2363 + #2333 + #2375 + #2372 are queued together for merge on branch main (8c054a1).
This pull request has been created by Mergify to check the mergeability of [#2376 + #2363 + #2333 + #2375 + #2372].
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
main queuefor merge:check-success = allRequired conditions to stay in the queue:
approved-reviews-by >= 1check-success = all_lightcheck-success = pre-commit.ci - pr