Conversation
Contributor
Author
kdaviduik
force-pushed
the
03-13-chore_delete_deploying.md
branch
from
March 14, 2026 22:53
018b0c0 to
c6173bc
Compare
kdaviduik
force-pushed
the
03-14-feat_migrate_npm-release.yml_to_oidc_trusted_publishing
branch
from
March 14, 2026 22:53
52ca1a3 to
9383c98
Compare
This was referenced Mar 14, 2026
kdaviduik
force-pushed
the
03-14-feat_migrate_npm-release.yml_to_oidc_trusted_publishing
branch
2 times, most recently
from
March 15, 2026 02:39
8ebf841 to
cfb88ff
Compare
kdaviduik
force-pushed
the
03-13-chore_delete_deploying.md
branch
from
March 15, 2026 02:39
c6173bc to
215a2cc
Compare
kdaviduik
changed the base branch from
03-13-chore_delete_deploying.md
to
graphite-base/952
March 18, 2026 19:01
kdaviduik
force-pushed
the
03-14-feat_migrate_npm-release.yml_to_oidc_trusted_publishing
branch
from
September 15, 2026 21:51
cfb88ff to
4a595c2
Compare
Replace static NPM_TOKEN authentication with OIDC token exchange for npm publishing. OIDC provides short-lived tokens derived from the GitHub Actions workflow identity, eliminating the risk of long-lived credential compromise. Key changes: - Remove NODE_AUTH_TOKEN env var (leaving it undefined triggers OIDC) - Set NPM_TOKEN to empty string (forces OIDC fallback) - Add a Test OIDC Token step that verifies the OIDC token exchange succeeds before the publish step runs - Fix package.json repository field from SSH shorthand to structured HTTPS format (required for OIDC provenance attestation) - id-token: write permission already present on main Node 24 (bundling npm 11 with native OIDC support) already landed on main via PR #955, so no node bump is needed here. Build gate: verified build + 794 tests pass on Node 24.14.0 (npm 11.9.0) Snapit OIDC migration deferred — only npm-release.yml is configured as a Trusted Publisher on npmjs.com. Snapit continues using NPM_TOKEN. Co-Authored-By: Claude <noreply@anthropic.com>
kdaviduik
force-pushed
the
03-14-feat_migrate_npm-release.yml_to_oidc_trusted_publishing
branch
from
September 15, 2026 21:54
4a595c2 to
d0d0ef2
Compare
kdaviduik
marked this pull request as ready for review
September 15, 2026 21:55
EvilGenius13
approved these changes
Sep 15, 2026
kdaviduik
deleted the
03-14-feat_migrate_npm-release.yml_to_oidc_trusted_publishing
branch
September 15, 2026 22:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/Shopify/developer-tools-team/issues/1195
Summary
NPM_TOKENto OIDC trusted publishingpackage.jsonrepository field from SSH shorthand to structured HTTPS format (required for provenance attestation, which is a prerequisite for OIDC trusted publishing)Why
OIDC replaces long-lived
NPM_TOKENsecrets with short-lived tokens derived from the GitHub Actions workflow identity. This eliminates the risk of credential compromise — tokens are scoped to the specific workflow run and cannot be reused. Standard at Shopify (Hydrogen, CLI, theme-tools, flash-list).npm classic tokens were revoked December 9, 2025. This repo's
NPM_TOKENwas a classic token, so it's already dead and this migration is a necessity in order to do future npm releases.How OIDC works
id-token: writepermission allows the workflow to request an OIDC token from GitHubsetup-nodewithregistry-urlconfigures.npmrcfor authNODE_AUTH_TOKENis NOT set — this causes npm to fall through to OIDC token exchangeNPM_TOKEN: ''(empty string) explicitly forces OIDC fallbackSnapit
(similar to Hydrogen) Snapit OIDC migration is deferred. Only
npm-release.ymlis configured as a Trusted Publisher on npmjs.com. To get/snapitto work we would need to move the contents of the snapit.yml into npm-release.yml./snapitto test our changes and verify everything works. We can instead just manually build this package and use that rather than the npm release from/snapit