Acquire semian resource for each retry in Active Record adapters - #1034
Draft
gmcgibbon wants to merge 2 commits into
Draft
Acquire semian resource for each retry in Active Record adapters#1034gmcgibbon wants to merge 2 commits into
gmcgibbon wants to merge 2 commits into
Conversation
gmcgibbon
requested review from
adrianna-chang-shopify,
nvasilevski and
that-jill
March 5, 2026 23:15
gmcgibbon
force-pushed
the
acquire_on_individual_retries
branch
from
March 5, 2026 23:45
34f3a64 to
aa07544
Compare
gmcgibbon
marked this pull request as draft
March 6, 2026 08:46
Previously, Active Record adapters would retry queries within the same acquisition attempt. Now, we wrap individual executions to ensure each retry is counted as one acquisition request.
gmcgibbon
force-pushed
the
acquire_on_individual_retries
branch
from
March 6, 2026 08:48
aa07544 to
7466135
Compare
Member
Author
|
Making retries happen at the |
Makes the dev container build properly.
gmcgibbon
force-pushed
the
acquire_on_individual_retries
branch
from
March 6, 2026 08:56
7498cd9 to
cc2724c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Active Record adapters would retry queries within the same acquisition attempt. Now, we wrap individual executions to ensure each retry is counted as one acquisition request.