Update workflow to use build script - #233
Open
peterjan wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR switches the GitHub Actions build workflow from inlined .deb construction to the repository’s scripts/build-deb.sh packaging script (backed by packages/<project> definitions), and updates the README to document the new package layout/behavior and additional supported daemons.
Changes:
- Update
README.mdwith expanded install/config/upgrade/removal documentation and addwalletd+s3dto the supported package list. - Refactor
.github/workflows/build.ymlto build.debartifacts viascripts/build-deb.shand upload/download a unifieddebsartifact for repository publishing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Documents the new packaging behavior (paths, conffiles, upgrades), adds walletd/s3d, and expands usage guidance. |
| .github/workflows/build.yml | Uses scripts/build-deb.sh + packages/<project> definitions instead of hand-assembling .deb contents in the workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
n8mgr
reviewed
Jun 17, 2026
peterjan
force-pushed
the
pj/deb-packages
branch
from
June 18, 2026 12:44
6b6e0aa to
f81a230
Compare
peterjan
force-pushed
the
pj/deb-workflow
branch
from
June 18, 2026 15:31
772d254 to
994d44b
Compare
peterjan
force-pushed
the
pj/deb-workflow
branch
from
June 18, 2026 15:42
994d44b to
3826c6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips the release flow over to the package definitions added in the previous PR and documents the new behaviour.
Fixes #129
Fixes #179