Adopt shared CI workflow and quality-check scripts; fix stale docs - #4
Merged
Merged
Conversation
Replaces the monolithic quality-checks.yml (inline PHP x WP matrix) with
the reusable workflow from silverassist/wp-coding-standards, plus a
dedicated compatibility job. Kept the repo's own security-check job
(eval()/$_GET/$_POST/remote-file_get_contents patterns) alongside the
standard composer-audit security-scan.
scripts/install-wp-tests.sh is now a thin wrapper delegating to
vendor/silverassist/wp-coding-standards.
Also fixed copilot-instructions.md, which still described the pre-kernel
architecture ("Singleton pattern (get_instance()) — not LoadableInterface")
even though this plugin was migrated to silverassist/wp-plugin-kernel
earlier this session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the portfolio-wide standardization effort (see
silverassist/wp-coding-standardsv1.1.5):quality-checks.ymlwith the reusable workflow, plus a dedicatedcompatibilityjob (real WP-version matrix).security-checkjob alongside the standardsecurity-scan.scripts/install-wp-tests.shis now a thin wrapper delegating tovendor/silverassist/wp-coding-standards/scripts/install-wp-tests.sh.copilot-instructions.md, which still described the pre-kernel architecture even though this plugin was migrated tosilverassist/wp-plugin-kernelearlier this session.Test plan
composer phpcs/vendor/bin/phpstan analyse --memory-limit=1Gpass locally