Skip to content

Docs/webhook events openapi registry - #273

Open
OmniZlatoon wants to merge 1 commit into
SmartDropLabs:mainfrom
OmniZlatoon:docs/webhook-events-openapi-registry
Open

Docs/webhook events openapi registry#273
OmniZlatoon wants to merge 1 commit into
SmartDropLabs:mainfrom
OmniZlatoon:docs/webhook-events-openapi-registry

Conversation

@OmniZlatoon

Copy link
Copy Markdown

Description

Centralized webhook event definitions so the legacy VALID_EVENTS export stays synchronized with the canonical event registry. Added regression coverage to prevent future event-list drift.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Files Modified

  • src/services/webhooks.js
  • test/webhooks.test.js

Testing

  • Tested locally
  • Added unit tests
  • Tested on Stellar Testnet (for wallet/contract changes)

Code Quality checks

  • Focused webhook tests passed: 26 tests
  • Worktree is clean
  • Changes pushed to docs/webhook-events-openapi-registry

Behavioural Changes

  • VALID_EVENTS now references the canonical webhookEvents.ALL_EVENTS registry.
  • Existing consumers retain the same export API.
  • Future event additions automatically remain synchronized.

Related Issues

Closes #127

@OmniZlatoon OmniZlatoon closed this Sep 3, 2026
@OmniZlatoon OmniZlatoon reopened this Sep 3, 2026
@OmniZlatoon
OmniZlatoon force-pushed the docs/webhook-events-openapi-registry branch from ad10682 to e6f7f65 Compare September 3, 2026 06:19
@OmniZlatoon

Copy link
Copy Markdown
Author

Good day sir @prodbycorne , please review PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README-documented pool.* webhook events are never dispatched anywhere in the codebase — subscriptions are permanently, silently dead

1 participant