fix: Post error for negative toplevel size hints - #2187
Merged
Merged
Conversation
The xdg-shell protocol states that the width and height for xdg_toplevel::set_min_size and xdg_toplevel::set_max_size must be greater than or equal to zero and attempting to set negative width/height values should raise an invalid_size error. Previously, smithay would not post an invalid_size error for such cases. Additionally, because the toplevel handler converts these values into a smithay::utils::Size, this would trigger an abort due to the debug_assert for negative sizes on Size::new for debug builds.
EVV1E
force-pushed
the
error_negative_size_hint
branch
from
September 28, 2026 15:56
d6c84f4 to
803ead1
Compare
Contributor
Author
|
I forgot to add a CHANGELOG.md entry up until now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The xdg-shell protocol states that the width and height for xdg_toplevel::set_min_size and xdg_toplevel::set_max_size must be greater than or equal to zero and attempting to set negative width/height values should raise an invalid_size error.
Previously, smithay would not post an invalid_size error for such cases.
Additionally, because the toplevel handler converts these values into a smithay::utils::Size, this would trigger an abort due to the debug_assert for negative sizes on Size::new for debug builds.
Checklist