Skip to content

Pre-size valdi_core bridge dictionaries and maps #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ultramiraculous wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pre-size valdi_core bridge dictionaries and maps #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb33a3a
Pre-size dictionaries when converting valdi Values to NSDictionary
ultramiraculous Jul 10, 2026
2381bb1
Reserve ValueMap capacity when converting NSDictionary to valdi Value
ultramiraculous Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions valdi_core/src/valdi_core/ios/valdi_core/SCValdiObjCConversionUtils.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,9 @@ id NSObjectFromValue(const Valdi::Value &value) {
return @(value.toBool());
case Valdi::ValueType::Map:
{
NSMutableDictionary *dictionary = [NSMutableDictionary dictionary];
for (const auto &it : *value.getMap()) {
const auto &valueMap = *value.getMap();
NSMutableDictionary *dictionary = [NSMutableDictionary dictionaryWithCapacity:valueMap.size()];
for (const auto &it : valueMap) {
dictionary[NSStringFromString(it.first)] = NSObjectFromValue(it.second);
}

Expand All @@ -244,7 +245,7 @@ id NSObjectFromValue(const Valdi::Value &value) {
case Valdi::ValueType::TypedObject:
{
const auto &typedObject = *value.getTypedObject();
NSMutableDictionary *dictionary = [NSMutableDictionary dictionary];
NSMutableDictionary *dictionary = [NSMutableDictionary dictionaryWithCapacity:typedObject.getPropertiesSize()];
for (const auto &property: typedObject) {
dictionary[NSStringFromString(property.name)] = NSObjectFromValue(property.value);
}
Expand Down Expand Up @@ -348,6 +349,7 @@ id NSObjectFromValue(const Valdi::Value &value) {

Valdi::Value ValueFromNSDictionary(NSDictionary<NSString *, id> *dict) {
auto map = Valdi::makeShared<Valdi::ValueMap>();
map->reserve(dict.count);
for (NSString *key in dict) {
id value = [dict objectForKey:key];
auto weakValue = ValueFromNSObject(value);
Expand Down
Loading