Fix localized preview toolbar actions - #3
Open
wadjj wants to merge 1 commit into
Open
Conversation
wadjj
marked this pull request as ready for review
August 18, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Change Modeaction name using the same locale mapping as MarkEdit-preview (Change Mode,切换模式, or切換模式)Why
MarkEdit custom toolbar actions are resolved by their visible main-menu title. Direct Preview always wrote the English
Change Modetitle, while MarkEdit-preview registers localized titles for Simplified and Traditional Chinese. On a Chinese system, the eye toolbar button therefore could not find its action and did nothing.User impact
The one-click preview toolbar button now works in English, Simplified Chinese, and Traditional Chinese. Existing configurations are migrated on the next Apply One-Click Toggle Setup… without creating duplicate buttons.
Validation
./node_modules/.bin/tsc --noEmitnpm test(Vite production build plus 6 passing Node tests)