Skip to content

ci: stop hiding the preview base marker from its own artifact #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Atharva0506 merged 1 commit into from
Sep 4, 2026
Merged

ci: stop hiding the preview base marker from its own artifact #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/pr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,10 @@ jobs:
npm run build -- --mode preview --base "$base"

# Recorded so the publish job can refuse a build made for the wrong
# path, instead of publishing a page that loads nothing.
printf '%s' "$base" > dist/.preview-base
# path, instead of publishing a page that loads nothing. Not a
# dotfile: actions/upload-artifact leaves hidden files out of the
# artifact by default, and this has to survive the trip.
printf '%s' "$base" > dist/preview-base

# A CNAME means something only at the site root, and the root belongs
# to the production deploy.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,13 +178,13 @@ jobs:
# blank, which is worth an error rather than a puzzled contributor.
# Stripped of anything but path characters before being echoed, since
# the file came from the build.
built_base="$(tr -dc 'A-Za-z0-9/._-' < preview/.preview-base 2>/dev/null || true)"
built_base="$(tr -dc 'A-Za-z0-9/._-' < preview/preview-base 2>/dev/null || true)"
if [ "$built_base" != "$EXPECTED_BASE" ]; then
echo "::error::this build is for '${built_base:-<unset>}' but the site serves '${EXPECTED_BASE}'."
echo "::error::set PREVIEW_PUBLIC_BASE=${{ needs.resolve.outputs.base_path }} in frontend/.env.preview"
exit 1
fi
rm -f preview/.preview-base
rm -f preview/preview-base

- name: Publish to gh-pages
env:
Expand Down
Loading