Skip to content

fix(DSO-26715): bump js-yaml override to 3.15.2 - #121

Merged
nurislam03 merged 1 commit into
mainfrom
DSO-26715-fix-js-yaml-cve-2026-84375
Sep 11, 2026
Merged

fix(DSO-26715): bump js-yaml override to 3.15.2#121
nurislam03 merged 1 commit into
mainfrom
DSO-26715-fix-js-yaml-cve-2026-84375

Conversation

@nurislam03

Copy link
Copy Markdown
Contributor

https://mitarbeiterapp.atlassian.net/browse/DSO-26715

What has been done?

  • Bumped the js-yaml npm override in package.json to 3.15.2; regenerated package-lock.json (3.15.0 -> 3.15.2).

Why was this done?

  • CVE-2026-84375 (js-yaml empty-merge CPU DoS): 3.15.2 is the backport of the 4.3.2 fix for v3-only trees. The dep is transitive via @istanbuljs/load-nyc-config (^3.13.1, jest coverage chain), so the v3-range override is kept and just moved to the fixed version.

How to test the changes?

  1. npm install resolves cleanly, lockfile shows js-yaml 3.15.2 only
  2. npm run lint passes; npm test green (6 suites, 158 tests)

Co-authored-by: opencode <opencode@noreply.opencode.ai>
Co-authored-by: GitHub Copilot <copilot@noreply.github.com>
@nurislam03
nurislam03 marked this pull request as ready for review September 11, 2026 07:15
@nurislam03
nurislam03 requested a review from a team as a code owner September 11, 2026 07:15
@review-swarm

review-swarm Bot commented Sep 11, 2026

Copy link
Copy Markdown

Staffbase AI Code Review

Verdict: ✅ Approved

Diff classified as trivial (≤10 lines, ≤5 files). No reviewers run.

📌 Only the first push is reviewed automatically. After that, comment @swarm review to re-review the latest commit.

  • Risk tier: trivial
  • Size: XS (trivial to review)
  • Head commit: 6bd1246
  • Findings: 0 critical, 0 warning, 0 suggestions

Findings

No findings.


Bot commands
  • @swarm ignore <id> [<id>...] — dismiss one or more findings by id (space-separated, including criticals — review each one before dismissing).
  • @swarm ignore-all — dismiss every open warning/suggestion (criticals must be dismissed explicitly via ignore <id>).
  • @swarm reset-ignores — clear all dismissals on this PR.
  • @swarm review — re-run the review against the latest commit.

You can also resolve a non-critical inline conversation to ignore it (and unresolve to bring it back). Resolving a critical conversation is not supported — use ignore <id> instead.

To bypass the entire review (criticals included), apply the break-glass label to the PR.

Execution Steps (3)
  1. Filter Diff — ✅ completed
    • Files: 1, +1/-1 lines
  2. Reviewer Pipeline — ⏭️ skipped
    • Reason: trivial tier
  3. Judge Pass — ⏭️ skipped
    • Reason: trivial tier

@review-swarm review-swarm Bot added the size/XS Pull requests that are extra small and quick to review label Sep 11, 2026
@nurislam03 nurislam03 added the dev Pull Requests that deployed to dev label Sep 11, 2026

@robertvangor robertvangor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nurislam03
nurislam03 merged commit 5b82caf into main Sep 11, 2026
10 checks passed
@nurislam03
nurislam03 deleted the DSO-26715-fix-js-yaml-cve-2026-84375 branch September 11, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev Pull Requests that deployed to dev size/XS Pull requests that are extra small and quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants