Fix comm sort-order crash in package diffing; align minimal list with R 4.5 - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes found while setting up a fresh macOS install.
1. pixi-setup.sh:
comm: file 1 is not in sorted ordercommrequires both inputs to be sorted. Ininject_packages, the left-hand input is the output ofpixi global list --json | jq | tr, which is never sorted:This stays quiet on a first clean run, because the target env holds exactly one package at that point and a single line is trivially sorted. On any rerun into an env that already holds two or more packages,
commfails. Withset -o errexitthat kills the script outright, and sinceinject_packages r-baseruns beforeinject_packages python, the Python section never executes at all.Fix: sort the left-hand side, and pin
LC_ALL=Con both sides of bothcommcalls so the two inputs cannot be collated differently on a machine with a non-C locale.2. minimal_packages.txt: r-base 4.4 -> 4.5
The two lists disagreed: minimal pinned
r-base=4.4while full pinsr-base=4.5. Anyone installed from the minimal list then cannot addr-pecotmrlater, since every published build requiresr-base >=4.5,<4.6.0a0:Bumping minimal to 4.5 makes the two lists agree and keeps the minimal env forward-compatible. Happy to drop this commit if the 4.4 pin was deliberate.