fix(send): wire refreshQuote into Send and PayRequest QuoteCard (#39) - #89
Open
ghzhost wants to merge 1 commit into
Open
fix(send): wire refreshQuote into Send and PayRequest QuoteCard (#39)#89ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #39.
Problem
QuoteCardhas an existing Refresh button controlled by theonRefreshprop and an expired warning state telling users to refresh their rate, but neitherSend.tsxnorPayRequest.tsxpassedonRefresh. When an exchange quote expired, the review screen became a dead end without a way to refresh the rate.Solution
refreshQuotefromuseSendPayment, which callsquoteApi.refreshQuote(quote.id)and falls back to re-requesting a quote with the current form values.onRefresh={refreshQuote}to<QuoteCard />in bothsrc/pages/Send.tsxandsrc/pages/PayRequest.tsx.src/components/send/QuoteCard.test.tsxverifying the Refresh button renders whenonRefreshis provided, triggers the callback upon click, and displays the expired warning when expired.Verification
NODE_ENV=test npm test: 28 test suites, 117 tests passing.npm run build: Typecheck (tsc) and Vite bundle build pass cleanly with 0 errors.