chore!: raise minimum PHP version to 8.2 and modernize tooling - #200
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setMethods()call withonlyMethods()andaddMethods().Breaking Change
Validation
composer updatecomposer validate --no-check-publishcomposer test -- tests/ParentDelegationBuilderTest.phpcomposer testThe focused parent-delegation test passes: 2 tests, 2 assertions.
The full PHPUnit test suite passes.
Consideration
Don't drop support for PHP 7.4 to 8.1? But I'd would be in favor of bumping this so we can really start modernizing the codebase.
Closing note
I haven't ran Rector yet. I would like to do that based on the outcomes of this PR.